Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Update to Cython 0.29.30. #21530

Merged
merged 1 commit into from May 19, 2022
Merged

MAINT: Update to Cython 0.29.30. #21530

merged 1 commit into from May 19, 2022

Conversation

felixxm
Copy link
Contributor

@felixxm felixxm commented May 18, 2022

@mattip
Copy link
Member

mattip commented May 19, 2022

Please also pin environment.yml for conda builds

numpy/environment.yml

Lines 9 to 14 in ad10968

dependencies:
- python=3.9 #need to pin to avoid issues with builds
- cython
- compilers
- openblas
- nomkl

@felixxm
Copy link
Contributor Author

felixxm commented May 19, 2022

Please also pin environment.yml for conda builds

Pinned 👍

@mattip mattip merged commit 57961d2 into numpy:main May 19, 2022
@mattip
Copy link
Member

mattip commented May 19, 2022

mamba and conda have 0.29.30, so let's put this in. Maybe the conda pinning will rattle the gitpod build's cache and make the build pass.

@felixxm felixxm deleted the cython-0.29.30 branch May 19, 2022 17:07
@milotoor
Copy link

Really appreciate the work to merge this, the profiling bug has been killing me. Do you have a rough timeline for the 1.22 backport?

@charris
Copy link
Member

charris commented May 19, 2022

Do you have a rough timeline for the 1.22 backport?

1.22.4 should be out in a day or two.

rgommers added a commit to rgommers/numpy that referenced this pull request May 22, 2022
0.29.30 is the minimum version, but there's no need to pin to that
exact version.

This is a follow up to numpygh-21530

[skip azurepipelines]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants