Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MAINT: Update to Cython 0.29.29. #21514

Merged
merged 2 commits into from May 17, 2022
Merged

MAINT: Update to Cython 0.29.29. #21514

merged 2 commits into from May 17, 2022

Conversation

felixxm
Copy link
Contributor

@felixxm felixxm commented May 16, 2022

Issue #21316.

@EwoutH
Copy link
Contributor

EwoutH commented May 16, 2022

You're fast, +1!

@charris
Copy link
Member

charris commented May 16, 2022

It's not yet available from PyPI :)

@charris
Copy link
Member

charris commented May 16, 2022

setup.py also needs updating.

@felixxm
Copy link
Contributor Author

felixxm commented May 16, 2022

setup.py also needs updating.

Updated 👍

@felixxm
Copy link
Contributor Author

felixxm commented May 16, 2022

It's not yet available from PyPI :)

It looks like we have to wait for GA, https://github.com/cython/cython/runs/6451267445?check_suite_focus=true.

@EwoutH
Copy link
Contributor

EwoutH commented May 16, 2022

It looks like we have to wait for GA, https://github.com/cython/cython/runs/6451267445?check_suite_focus=true.

That queue is insane, over 100 jobs waiting

@felixxm
Copy link
Contributor Author

felixxm commented May 16, 2022

Released https://pypi.org/project/Cython/0.29.29/ 🚀

@charris
Copy link
Member

charris commented May 16, 2022

Looks like conda hasn't got it yet. I'll wait a day or two for that, but put this in before branching in any case.

@mattip
Copy link
Member

mattip commented May 17, 2022

conda-forge has the release. Reopening to try again

@mattip mattip closed this May 17, 2022
@mattip mattip reopened this May 17, 2022
@seberg seberg added the 09 - Backport-Candidate PRs tagged should be backported label May 17, 2022
@seberg seberg added this to the 1.22.4 release milestone May 17, 2022
@mattip mattip merged commit f40ed30 into numpy:main May 17, 2022
@mattip
Copy link
Member

mattip commented May 17, 2022

Thanks @felixxm

@EwoutH
Copy link
Contributor

EwoutH commented May 17, 2022

Could we backport this PR to the 1.22 maintenance branch? It might fix #21008.

@charris
Copy link
Member

charris commented May 17, 2022

@EwoutH Already marked for backport.

@felixxm felixxm deleted the issue-21316 branch May 17, 2022 13:25
charris added a commit to charris/numpy that referenced this pull request May 17, 2022
@charris
MAINT: Update Cython version to 0.29.29.
cffe44d 
Adapted backport of numpy#21514.
@charris charris mentioned this pull request May 17, 2022
Merged
@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label May 17, 2022
@charris charris removed this from the 1.22.4 release milestone May 17, 2022
charris added a commit to charris/numpy that referenced this pull request May 17, 2022
@charris
MAINT: Update Cython version to 0.29.29.
197380e 
Adapted backport of numpy#21514.
@charris
Copy link
Member

charris commented May 17, 2022

Note that the gitpod build failed on merge, 0.29.29 is not yet available in mamba.

@charris
Copy link
Member

charris commented May 17, 2022

And now 0.29.30 is out :)

@felixxm
Copy link
Contributor Author

felixxm commented May 17, 2022

Quite surprising 🎁 I can prepare a new PR when it becomes available on PyPI.

charris added a commit to charris/numpy that referenced this pull request May 17, 2022
@charris
MAINT: Update Cython version to 0.29.29.
14be617 
Adapted backport of numpy#21514.
@felixxm felixxm mentioned this pull request May 18, 2022
Merged
@felixxm
Copy link
Contributor Author

felixxm commented May 18, 2022

I prepare #21530 for the main branch.

@EwoutH EwoutH mentioned this pull request May 20, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
03 - Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@felixxm @EwoutH @charris @mattip @seberg