Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests/Docs: Update tests to Cython 0.29.30, mention in docs #21545

Merged
merged 1 commit into from May 21, 2022

Conversation

EwoutH
Copy link
Contributor

@EwoutH EwoutH commented May 20, 2022

Cython 0.29.30 is required for building Numpy with Python 3.11. This commit updates that in the core/tests/test_cython.py and random/tests/test_exending.py files.

It also mentions that Cython 0.29.30 is needed in the INSTALL documentation.

This PR is a small follow-up on #21514 and #21530. It might also be needed to be backported, to the 1.22.x maintenance branch, like #21525.

Cython 0.29.30 is required for building Numpy with Python 3.11. This commit updates that in the core/tests/test_cython.py and random/tests/test_exending.py files.

It also mentions that Cython 0.29.30 is needed in the INSTALL documentation.
@mattip
Copy link
Member

mattip commented May 20, 2022

Thanks. Perhaps we should have a better way to sync all these places.

@mattip mattip added 09 - Backport-Candidate PRs tagged should be backported 36 - Build Build related PR 03 - Maintenance and removed 36 - Build Build related PR labels May 20, 2022
@charris charris merged commit dd03f4f into numpy:main May 21, 2022
@charris
Copy link
Member

charris commented May 21, 2022

Thanks @EwoutH . I'm going to omit backporting as tests pass and I don't plan more 1.22.x releases. 1.23.x will be the first to support Python 3.11.

@charris charris removed the 09 - Backport-Candidate PRs tagged should be backported label May 21, 2022
@InessaPawson
Copy link
Member

Hi-five on merging your first pull request to NumPy, @EwoutH! We hope you stick around! Your choices aren’t limited to programming – you can review pull requests, help us stay on top of new and old issues, develop educational material, work on our website, add or improve graphic design, create marketing materials, translate website content, write grant proposals, and help with other fundraising initiatives. For more info, check out: https://numpy.org/contribute
Also, consider joining our mailing list. This is a great way to connect with other cool people in our community and be part of important conversations that affect the development of NumPy: https://mail.python.org/mailman/listinfo/numpy-discussion

@EwoutH
Copy link
Contributor Author

EwoutH commented May 23, 2022

Thanks for the kind words and the info, @InessaPawson!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

4 participants