upgrade to node 20.9.0. ignore deprecated warnings to make nan compile. #7660
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alphaprinz The latest node I see in the downstream is 20.9.0, let's get this version. |
alphaprinz
changed the title
|
Hi @b-ranto, |
|
Yes, it passed before. I have scheduled one more d/s build for this branch as well and it also passed. |
dannyzaken
approved these changes
Dec 19, 2023
tangledbytes
approved these changes
Dec 19, 2023
The -Wno-error=deprecated-declarations flag can be removed when nodejs/nan#953 is resolved Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
dannyzaken
pushed a commit
to dannyzaken/noobaa-core
that referenced
this pull request
Dec 20, 2023
…e. (noobaa#7660) upgrade to node20. ignore deprecated warnings to make nan compile. The -Wno-error=deprecated-declarations flag can be removed when nodejs/nan#953 is resolved Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com> (cherry picked from commit bafd976)
Merged
2 tasks
dannyzaken
pushed a commit
to dannyzaken/noobaa-core
that referenced
this pull request
Dec 20, 2023
…e. (noobaa#7660) upgrade to node20. ignore deprecated warnings to make nan compile. The -Wno-error=deprecated-declarations flag can be removed when nodejs/nan#953 is resolved Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com> (cherry picked from commit bafd976) Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
liranmauda
pushed a commit
to liranmauda/noobaa-core
that referenced
this pull request
Apr 9, 2024
…e. (noobaa#7660) upgrade to node20. ignore deprecated warnings to make nan compile. The -Wno-error=deprecated-declarations flag can be removed when nodejs/nan#953 is resolved Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com> (cherry picked from commit bafd976)
liranmauda
pushed a commit
to liranmauda/noobaa-core
that referenced
this pull request
Apr 9, 2024
…e. (noobaa#7660) upgrade to node20. ignore deprecated warnings to make nan compile. The -Wno-error=deprecated-declarations flag can be removed when nodejs/nan#953 is resolved Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com> (cherry picked from commit bafd976) Signed-off-by: liranmauda <liran.mauda@gmail.com>
liranmauda
pushed a commit
to liranmauda/noobaa-core
that referenced
this pull request
Apr 16, 2024
…e. (noobaa#7660) upgrade to node20. ignore deprecated warnings to make nan compile. The -Wno-error=deprecated-declarations flag can be removed when nodejs/nan#953 is resolved Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com> (cherry picked from commit bafd976) Signed-off-by: liranmauda <liran.mauda@gmail.com>
liranmauda
pushed a commit
to liranmauda/noobaa-core
that referenced
this pull request
Apr 16, 2024
…e. (noobaa#7660) upgrade to node20. ignore deprecated warnings to make nan compile. The -Wno-error=deprecated-declarations flag can be removed when nodejs/nan#953 is resolved Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com> (cherry picked from commit bafd976) Signed-off-by: liranmauda <liran.mauda@gmail.com>
liranmauda
added a commit
that referenced
this pull request
Apr 17, 2024
[Backport to 5.14] upgrade to node 20.11.0. ignore deprecated warnings to make nan compile. (#7660)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade node to 20.9.0.
Nan have compilation warning which -Wextra makes into an error.
-Wno-error=deprecated-declarations flag was added to bypass this.
The -Wno-error=deprecated-declarations flag can be removed when nodejs/nan#953
is resolved
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: