Skip to content

Commit

Permalink
upgrade to node 20.9.0. ignore deprecated warnings to make nan compil…
Browse files Browse the repository at this point in the history
…e. (#7660)

upgrade to node20. ignore deprecated warnings to make nan compile.

The -Wno-error=deprecated-declarations flag can be removed when
nodejs/nan#953
is resolved

Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com>
  • Loading branch information
alphaprinz committed Dec 19, 2023
1 parent 0cea777 commit bafd976
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 1 addition & 1 deletion .nvmrc
@@ -1 +1 @@
18.18.2
20.9.0
2 changes: 2 additions & 0 deletions src/native/common.gypi
Expand Up @@ -7,6 +7,8 @@
'-Wextra',
'-Werror',
'-Wpedantic',
#Can be removed when https://github.com/nodejs/nan/issues/953 is resolved.
'-Wno-error=deprecated-declarations'
],
# see https://nodejs.org/docs/latest-v12.x/api/process.html#process_process_arch
# Possible values are:
Expand Down

0 comments on commit bafd976

Please sign in to comment.