[Backport to 5.15] upgrade to node 20.9.0. ignore deprecated warnings to make nan compile #7669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannyzaken
changed the title
…e. (noobaa#7660) upgrade to node20. ignore deprecated warnings to make nan compile. The -Wno-error=deprecated-declarations flag can be removed when nodejs/nan#953 is resolved Signed-off-by: Amit Prinz Setter <alphaprinz@gmail.com> (cherry picked from commit bafd976) Signed-off-by: Danny Zaken <dannyzaken@gmail.com>
dannyzaken
force-pushed
the
danny-5.15
branch
from
3b2772b
to
c9766f2
Compare
nimrod-becker
approved these changes
Dec 20, 2023
|
Please make sure @b-ranto is aware. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(#7660)
upgrade to node20. ignore deprecated warnings to make nan compile.
The -Wno-error=deprecated-declarations flag can be removed when nodejs/nan#953
is resolved
Signed-off-by: Amit Prinz Setter alphaprinz@gmail.com
(cherry picked from commit bafd976)
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions: