New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Annotate IContainer so Psalm knows what resove and query return #23377
Conversation
🙈 |
The encryption app needs to move from those random names to just use the full namespace and then most of this is done. |
Also then most of the encryption app can be auto wired ;) |
While that is true it's still ok to use string that are not a FQCN. Let me see if we can teach Psalm that. |
The last commit will be removed. I'm just testing vimeo/psalm#4310. |
25f0568
to
95ea74f
Compare
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
95ea74f
to
f9f20b6
Compare
Rebased because other PR was merged. |
Only 4 errors left 🙌 |
But in other news these are new errors detected because of the typing 🚀 |
/backport f9f20b6 to stable20 |
@ChristophWurst Ready for review, right? |
2ffc565
to
0644a74
Compare
This comment has been minimized.
This comment has been minimized.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
0644a74
to
f464ef0
Compare
Fixed 🙏 |
@@ -68,14 +68,14 @@ public function search($search, array $shareTypes, $lookup, $limit, $offset) { | |||
foreach ($this->pluginList[$type] as $plugin) { | |||
/** @var ISearchPlugin $searchPlugin */ | |||
$searchPlugin = $this->c->resolve($plugin); | |||
$hasMoreResults |= $searchPlugin->search($search, $limit, $offset, $searchResult); | |||
$hasMoreResults = $searchPlugin->search($search, $limit, $offset, $searchResult) || $hasMoreResults; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@blizzz hope the logic is unchanged. The search
call should always happen no matter the value of $hasMoreResults
, right? Asking because there might be semantics of the short-circuit evaluation of an or.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah right ... but yes - the search should happen in every plugin and then it is combined afterwards.
🤖 beep boop beep 🤖 Here are the logs for the failed build: Status of 34135: failureacceptance-users
Show full log
|
@kesselb IIRC you wanted to add this some time ago. Were there any issues?