Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable20] Annotate IContainer so Psalm knows what resove and query return #23446

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Oct 14, 2020

backport of #23377

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
@faily-bot
Copy link

faily-bot bot commented Oct 14, 2020

🤖 beep boop beep 🤖

Here are the logs for the failed build:

Status of 34136: failure

mariadb10.1-php7.2

Show full log
There was 1 error:

1) Test\Files\Storage\Wrapper\PermissionsMaskTest::testScanNewWrappedFiles
Error: Call to a member function getPermissions() on boolean

/drone/src/tests/lib/Files/Storage/Wrapper/PermissionsMaskTest.php:126

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

mariadb10.2-php7.2

Show full log
There was 1 error:

1) OCA\ShareByMail\Tests\ShareByMailProviderTest::testUpdate
OCP\Share\Exceptions\ShareNotFound: There was an error retrieving the share. Maybe the link is wrong, it was unshared, or it was deleted.

/drone/src/apps/sharebymail/lib/ShareByMailProvider.php:830
/drone/src/apps/sharebymail/lib/ShareByMailProvider.php:691
/drone/src/apps/sharebymail/tests/ShareByMailProviderTest.php:589

--

There were 2 warnings:

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

--

There was 1 failure:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #248 ('folder', 31, 15)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

mysql8.0-php7.2

  • cancelled - typically means that the tests took longer than the drone CI allows them to run

Copy link
Member

@MorrisJobke MorrisJobke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@MorrisJobke MorrisJobke added the 3. to review Waiting for reviews label Oct 14, 2020
@MorrisJobke MorrisJobke merged commit 5e9e906 into stable20 Oct 14, 2020
@MorrisJobke MorrisJobke deleted the backport/23377/stable20 branch October 14, 2020 15:40
@MorrisJobke MorrisJobke mentioned this pull request Oct 15, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants