Look into unstable tests #22305

MorrisJobke · 2020-08-19T19:28:18Z

Those tests fail from time to time:

#23437 & #23567 & #23626 & #23729 & #23752 & #23204:

1) OCA\Files_Sharing\Tests\EtagPropagationTest::testReshareRecipientWritesToReshare
Error: Call to a member function getMountPoint() on null

/drone/src/lib/private/Share20/Manager.php:304
/drone/src/lib/private/Share20/Manager.php:705
/drone/src/apps/files_sharing/tests/EtagPropagationTest.php:94
/drone/src/apps/files_sharing/tests/PropagationTestCase.php:42

1) OCA\Files_Versions\Tests\VersioningTest::testRestoreMovedShare
File content has not changed
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'version 2'
+'version 1'

/drone/src/apps/files_versions/tests/VersioningTest.php:729

1) OCA\FederatedFileSharing\Tests\FederatedShareProviderTest::testGetSharedBy
OCP\Share\Exceptions\ShareNotFound: There was an error retrieving the share. Maybe the link is wrong, it was unshared, or it was deleted.

/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:863
/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:242
/drone/src/apps/federatedfilesharing/tests/FederatedShareProviderTest.php:524

1) Test\Files\ObjectStore\ObjectStoreStorageTest::testCopyOverwrite with data set #5 ('/sòurcē.txt', '/target.txt')
Expected /target.txt to be a copy of /drone/src/tests/data/lorem.txt
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'Lorem ipsum dolor sit amet, consectetur adipisicing elit, sed do eiusmod tempor incididunt ut labore et dolore magna aliqua.\n
-Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi ut aliquip ex ea commodo consequat.\n
-Duis aute irure dolor in reprehenderit in voluptate velit esse cillum dolore eu fugiat nulla pariatur.\n
-Excepteur sint occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim id est laborum.'
+''

/drone/src/tests/lib/Files/Storage/Storage.php:222
/drone/src/tests/lib/Files/Storage/Storage.php:263

1) OCA\DAV\Tests\unit\CardDAV\CardDavBackendTest::testSearch with data set "check if duplicates are handled correctly" ('John', array('FN', 'CLOUD'), array(), array(array('uri0', 'John Doe'), array('uri1', 'John M. Doe')))
108	Failed asserting that 1 is identical to 2.
109	
110	/drone/src/apps/dav/tests/unit/CardDAV/CardDavBackendTest.php:746

OCA\FederatedFileSharing\Tests\FederatedShareProviderTest::testGetSharedByWithLimit
98	OCP\Share\Exceptions\ShareNotFound: There was an error retrieving the share. Maybe the link is wrong, it was unshared, or it was deleted.
99	
100	/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:865
101	/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:244
102	/drone/src/apps/federatedfilesharing/tests/FederatedShareProviderTest.php:655

We should make them more reliable to avoid false positives.

cc @nickvergessen @kesselb @ChristophWurst @rullzer

The text was updated successfully, but these errors were encountered:

MorrisJobke · 2020-10-13T15:32:07Z

✅ disabled in #23492

#23402:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #155 ('folder', 11, 9)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

#23422:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #164 ('folder', 13, 5)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

#23446:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #248 ('folder', 31, 15)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

#23466:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #7 ('file', 17, 3)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

#23466:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #93 ('folder', 19, 23)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

#15999:

2) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #26 ('folder', 1, 31)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:367

MorrisJobke · 2020-10-13T15:36:12Z

#23405, #23437:

1) OCA\Files_Sharing\Tests\SharedMountTest::testPermissionMovedGroupShare with data set #243 ('folder', 31, 21)
Failed asserting that false is true.

/drone/src/apps/files_sharing/tests/SharedMountTest.php:361

MorrisJobke · 2020-10-13T15:46:09Z

#23395:

There was 1 failure:

1) Test\Files\Cache\CacheTest::testSimple
Failed asserting that 0 matches expected 66.

/drone/src/tests/lib/Files/Cache/CacheTest.php:70

MorrisJobke · 2020-10-13T15:47:47Z

I will keep track which one happens how often and on the third strike it gets disabled.

MorrisJobke · 2020-10-13T15:51:16Z

#23410 & #23401 & #23336:

tests/acceptance/features/apps.feature:34

 Scenario: Browse app bundles                           # /drone/src/tests/acceptance/features/apps.feature:34
    Given I act as Jane                                  # ActorContext::iActAs()
    And I am logged in as the admin                      # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the Apps management                       # SettingsMenuContext::iOpenTheAppsManagement()
    When I open the "App bundles" section                # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "App bundles" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I see the app bundles                            # AppsManagementContext::iSeeTheAppBundles()
      Row for app Auditing / Logging in Apps Management could not be found after 20 seconds (NoSuchElementException)
    And I see that the "Enterprise bundle" is disabled   # AppsManagementContext::iSeeThatTheIsDisabled()

MorrisJobke · 2020-10-13T19:10:54Z

#23424 & #23621 & #23680:

1) Test\Files\Cache\UpdaterLegacyTest::testWrite
Failed asserting that 1602612817 is equal to 1602612818 or is greater than 1602612818.

/drone/src/tests/lib/Files/Cache/UpdaterLegacyTest.php:118

other output:


Failed asserting that 1603365292 is equal to 1603365293 or is greater than 1603365293.
Failed asserting that 1603650101 is equal to 1603650102 or is greater than 1603650102.

MorrisJobke · 2020-10-13T19:44:35Z

#23420 & #23479:

tests/acceptance/features/header.feature:57

  Scenario: search for other users in the contacts menu                              # /drone/src/tests/acceptance/features/header.feature:57
    Given I am logged in as the admin                                                # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                                     # SettingsMenuContext::iOpenTheUserSettings()
    And I click the New user button                                                  # UsersSettingsContext::iClickTheNewUserButton()
      New user button in Users Settings could not be found (NoSuchElementException)
    And I see that the new user form is shown                                        # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
    And I create user user1 with password 123456acb                                  # UsersSettingsContext::iCreateUserWithPassword()
    And I see that the list of users contains the user user1                         # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    And I open the Contacts menu                                                     # ContactsMenuContext::iOpenTheContactsMenu()
    And I see that the Contacts menu is shown                                        # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
    And I see that the contact "user0" in the Contacts menu is shown                 # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
    And I see that the contact "user1" in the Contacts menu is shown                 # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
    And I see that the Contacts menu search input is shown                           # ContactsMenuContext::iSeeThatTheContactsMenuSearchInputIsShown()
    When I search for the user "user0"                                               # ContactsMenuContext::iSearchForTheUser()
    Then I see that the contact "user1" in the Contacts menu is eventually not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsEventuallyNotShown()
    And I see that the contact "user0" in the Contacts menu is shown                 # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
    And I see that the contact "admin" in the Contacts menu is not shown             # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

MorrisJobke · 2020-10-14T14:54:27Z

✅ disabled in #23613

#23385 & #23336 & #23500 & #23564 & #23611:

tests/acceptance/features/app-files.feature:108

  Scenario: show shares                                               # /drone/src/tests/acceptance/features/app-files.feature:108
    Given I am logged in                                              # LoginPageContext::iAmLoggedIn()
    And I share the link for "welcome.txt"                            # FilesAppSharingContext::iShareTheLinkFor()
    When I open the "Shares" section                                  # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "Shares"                   # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    Then I see that the file list contains a file named "welcome.txt" # FileListContext::iSeeThatTheFileListContainsAFileNamed()
      Row for file welcome.txt in file list could not be found after 100 seconds (NoSuchElementException)

MorrisJobke · 2020-10-14T15:04:26Z

#23377:

tests/acceptance/features/users.feature:103

  Scenario: change columns visibility                          # /drone/src/tests/acceptance/features/users.feature:103
    Given I act as Jane                                        # ActorContext::iActAs()
    And I am logged in as the admin                            # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                               # SettingsMenuContext::iOpenTheUserSettings()
    And I open the settings                                    # AppSettingsContext::iOpenTheSettings()
      App settings could not be found
      The button to open the app settings could not be found (NoSuchElementException)
    And I see that the settings are opened                     # AppSettingsContext::iSeeThatTheSettingsAreOpened()
    When I toggle the showLanguages checkbox in the settings   # AppSettingsContext::iToggleTheCheckboxInTheSettingsTo()
    Then I see that the "Language" column is shown             # UsersSettingsContext::iSeeThatTheColumnIsShown()
    When I toggle the showLastLogin checkbox in the settings   # AppSettingsContext::iToggleTheCheckboxInTheSettingsTo()
    Then I see that the "Last login" column is shown           # UsersSettingsContext::iSeeThatTheColumnIsShown()
    When I toggle the showStoragePath checkbox in the settings # AppSettingsContext::iToggleTheCheckboxInTheSettingsTo()
    Then I see that the "Storage location" column is shown     # UsersSettingsContext::iSeeThatTheColumnIsShown()
    When I toggle the showUserBackend checkbox in the settings # AppSettingsContext::iToggleTheCheckboxInTheSettingsTo()
    Then I see that the "User backend" column is shown         # UsersSettingsContext::iSeeThatTheColumnIsShown()

MorrisJobke · 2020-10-14T15:39:33Z

#23446 & #23799:

1) Test\Files\Storage\Wrapper\PermissionsMaskTest::testScanNewWrappedFiles
Error: Call to a member function getPermissions() on boolean

/drone/src/tests/lib/Files/Storage/Wrapper/PermissionsMaskTest.php:126

MorrisJobke · 2020-10-14T15:39:47Z

#23446:

1) OCA\ShareByMail\Tests\ShareByMailProviderTest::testUpdate
OCP\Share\Exceptions\ShareNotFound: There was an error retrieving the share. Maybe the link is wrong, it was unshared, or it was deleted.

/drone/src/apps/sharebymail/lib/ShareByMailProvider.php:830
/drone/src/apps/sharebymail/lib/ShareByMailProvider.php:691
/drone/src/apps/sharebymail/tests/ShareByMailProviderTest.php:589

MorrisJobke · 2020-10-14T19:24:38Z

#23437:

1) Test\Share20\DefaultShareProviderTest::testGetSharedWithUserWithNode with data set #2 ('smb::whatever', 'files_trashbin/files/test.txt', 'files_trashbin/files/test2.txt')
Failed asserting that '66' matches expected 0.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:1148

MorrisJobke · 2020-10-15T11:25:15Z

#15999:

1) Test\Comments\ManagerTest::testGetForObjectSince with data set #5 (1, 'asc', 2, 2, 3)
Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 (
-    0 => 0
+    0 => 3
     1 => 4
 )
	
/drone/src/tests/lib/Comments/ManagerTest.php:381

#23759:

Failed asserting that two arrays are identical.
--- Expected
+++ Actual
@@ @@
 Array &0 (
-    0 => 0
+    0 => 3
     1 => 2
 )

/drone/src/tests/lib/Comments/ManagerTest.php:383

MorrisJobke · 2020-10-15T11:54:53Z

#23336:

1) Test\Files\Cache\PropagatorTest::testSizePropagation
Failed asserting that 3 matches expected 13.

/drone/src/tests/lib/Files/Cache/PropagatorTest.php:80

MorrisJobke · 2020-10-15T11:56:17Z

#23336:

tests/acceptance/features/apps.feature:4
tests/acceptance/features/apps.feature:11
tests/acceptance/features/apps.feature:34
tests/acceptance/features/apps.feature:53

  Scenario: enable an installed app                       # /drone/src/tests/acceptance/features/apps.feature:4
    Given I act as Jane                                   # ActorContext::iActAs()
    And I am logged in as the admin                       # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the Apps management                        # SettingsMenuContext::iOpenTheAppsManagement()
    When I enable the "QA testing" app                    # AppsManagementContext::iEnableTheApp()
      Row for app QA testing in Apps Management could not be found after 100 seconds
      Enable button in the app list for QA testing could not be found after 100 seconds (NoSuchElementException)
    Then I see that the "QA testing" app has been enabled # AppsManagementContext::iSeeThatTheAppHasBeenEnabled()

  Scenario: disable a installed app                                 # /drone/src/tests/acceptance/features/apps.feature:11
    Given I act as Jane                                             # ActorContext::iActAs()
    And I am logged in as the admin                                 # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the Apps management                                  # SettingsMenuContext::iOpenTheAppsManagement()
    When I disable the "Update notification" app                    # AppsManagementContext::iDisableTheApp()
      Row for app Update notification in Apps Management could not be found after 100 seconds
      Disable button in the app list for Update notification could not be found after 100 seconds (NoSuchElementException)
    Then I see that the "Update notification" app has been disabled # AppsManagementContext::iSeeThatTheAppHasBeenDisabled()

  Scenario: Browse app bundles                           # /drone/src/tests/acceptance/features/apps.feature:34
    Given I act as Jane                                  # ActorContext::iActAs()
    And I am logged in as the admin                      # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the Apps management                       # SettingsMenuContext::iOpenTheAppsManagement()
    When I open the "App bundles" section                # AppNavigationContext::iOpenTheSection()
    Then I see that the current section is "App bundles" # AppNavigationContext::iSeeThatTheCurrentSectionIs()
    And I see the app bundles                            # AppsManagementContext::iSeeTheAppBundles()
      Row for app Auditing / Logging in Apps Management could not be found after 20 seconds (NoSuchElementException)
    And I see that the "Enterprise bundle" is disabled   # AppsManagementContext::iSeeThatTheIsDisabled()

  Scenario: View app details                  # /drone/src/tests/acceptance/features/apps.feature:53
    Given I act as Jane                       # ActorContext::iActAs()
    And I am logged in as the admin           # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the Apps management            # SettingsMenuContext::iOpenTheAppsManagement()
    When I click on the "QA testing" app      # AppsManagementContext::iClickOnTheApp()
      Row for app QA testing in Apps Management could not be found after 100 seconds (NoSuchElementException)
    Then I see that the app details are shown # AppsManagementContext::iSeeThatTheAppDetailsAreShown()

MorrisJobke · 2020-10-15T11:59:54Z

✅ disabled in #23614

#23438 & #23481 & #23488 & #23583:

tests/acceptance/features/app-files-sharing.feature:338

Scenario: sharee can revoke create permission from reshare after the sharer disabled it # /drone/src/tests/acceptance/features/app-files-sharing.feature:338
    Given I act as John                                                                   # ActorContext::iActAs()
    And I am logged in as the admin                                                       # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I act as Jane                                                                     # ActorContext::iActAs()
    And I am logged in                                                                    # LoginPageContext::iAmLoggedIn()
    And I act as Jim                                                                      # ActorContext::iActAs()
    And I am logged in as "user1"                                                         # LoginPageContext::iAmLoggedInAs()
    And I act as John                                                                     # ActorContext::iActAs()
    And I create a new folder named "Shared folder"                                       # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Shared folder"                    # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    And I share "Shared folder" with "user0"                                              # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user0"                                        # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as Jane                                                                     # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I share "Shared folder" with "user1"                                              # FilesAppSharingContext::iShareWith()
    And I see that the file is shared with "user1"                                        # FilesAppSharingContext::iSeeThatTheFileIsSharedWith()
    And I act as John                                                                     # ActorContext::iActAs()
    And I set the share with "user0" as not creatable                                     # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
    And I see that "user0" can not create in the share                                    # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
    And I act as Jim                                                                      # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I enter in the folder named "Shared folder"                                       # FileListContext::iEnterInTheFolderNamed()
    And I create a new folder named "Subfolder"                                           # FileListContext::iCreateANewFolderNamed()
    And I see that the file list contains a file named "Subfolder"                        # FileListContext::iSeeThatTheFileListContainsAFileNamed()
    When I act as Jane                                                                    # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I open the details view for "Shared folder"                                       # FileListContext::iOpenTheDetailsViewFor()
    And I see that the details view is open                                               # FilesAppContext::iSeeThatTheDetailsViewIsOpen()
    And I open the "Sharing" tab in the details view                                      # FilesAppContext::iOpenTheTabInTheDetailsView()
    And I see that the "Sharing" tab in the details view is eventually loaded             # FilesAppContext::iSeeThatTheTabInTheDetailsViewIsEventuallyLoaded()
    And I set the share with "user1" as not creatable                                     # FilesAppSharingContext::iSetTheShareWithAsNotCreatable()
    Then I see that "user1" can not create in the share                                   # FilesAppSharingContext::iSeeThatCanNotCreateInTheShare()
    And I see that "user1" can not be allowed to create in the share                      # FilesAppSharingContext::iSeeThatCanNotBeAllowedToCreateInTheShare()
    And I act as Jim                                                                      # ActorContext::iActAs()
    And I open the Files app                                                              # FilesAppContext::iOpenTheFilesApp()
    And I enter in the folder named "Shared folder"                                       # FileListContext::iEnterInTheFolderNamed()
    And I see that it is not possible to create new files                                 # FileListContext::iSeeThatItIsNotPossibleToCreateNewFiles()
      Failed asserting that true is false.

MorrisJobke · 2020-10-16T07:33:42Z

#23491:

1) Test\Comments\ManagerTest::testGetForObjectWithDateTimeConstraint
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'4'
+'0'

/drone/src/tests/lib/Comments/ManagerTest.php:266

MorrisJobke · 2020-10-16T07:49:14Z

#23490:

1) Test\Files\Cache\Wrapper\CacheJailTest::testLongId
null does not match expected type "array".

/drone/src/tests/lib/Files/Cache/CacheTest.php:521

MorrisJobke · 2020-10-16T08:56:36Z

#23500:

1) Test\Repair\CleanTagsTest::testRun
Assert tag entries count after cleaning file entries
Failed asserting that '2' matches expected 3.

/drone/src/tests/lib/Repair/CleanTagsTest.php:124
/drone/src/tests/lib/Repair/CleanTagsTest.php:87

MorrisJobke · 2020-10-16T12:54:18Z

#23510 & #23567 & #23614 & #23630:

1) Test\Files\Cache\QuerySearchHelperTest::testComparison with data set #13 (OC\Files\Search\SearchBinaryOperator Object (...), array(1))
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 0
+    0 => '450'
 )

/drone/src/tests/lib/Files/Cache/QuerySearchHelperTest.php:212

MorrisJobke · 2020-10-22T13:19:49Z

#23623:

1) OCA\FederatedFileSharing\Tests\FederatedShareProviderTest::testCreateAlreadyShared
OCP\Share\Exceptions\ShareNotFound: There was an error retrieving the share. Maybe the link is wrong, it was unshared, or it was deleted.

/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:863
/drone/src/apps/federatedfilesharing/lib/FederatedShareProvider.php:242
/drone/src/apps/federatedfilesharing/tests/FederatedShareProviderTest.php:406

MorrisJobke · 2020-10-22T20:31:48Z

#23638:

1) Test\Share20\DefaultShareProviderTest::testGetSharedWithGroupWithNode with data set #0 ('home::shareOwner', 'files/test.txt', 'files/test2.txt')
Failed asserting that actual size 0 matches expected size 1.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:1190

MorrisJobke · 2020-10-23T11:36:01Z

#23627:

1) Test\Share20\DefaultShareProviderTest::testDeleteFromSelfLink
Failed asserting that exception of type "OCP\Share\Exceptions\ShareNotFound" matches expected exception "OC\Share20\Exception\ProviderException". Message was: "There was an error retrieving the share. Maybe the link is wrong, it was unshared, or it was deleted." at
/drone/src/lib/private/Share20/DefaultShareProvider.php:763
/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:1770

MorrisJobke · 2020-10-23T11:38:01Z

#23643:

1) Test\Share20\DefaultShareProviderTest::testDeleteUserGroup with data set #1 ('a', 'b', 'c', 'b', false, false)
Failed asserting that actual size 0 matches expected size 1.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:2320

#23746:

1) Test\Share20\DefaultShareProviderTest::testDeleteUserGroup with data set #3 ('a', 'b', 'c', 'd', false, false)
Failed asserting that actual size 0 matches expected size 1.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:2324

MorrisJobke · 2020-10-23T11:40:20Z

#23645:

tests/acceptance/features/users.feature:13

  Scenario: create a new user with a custom display name               # /drone/src/tests/acceptance/features/users.feature:13
    Given I am logged in as the admin                                  # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                       # SettingsMenuContext::iOpenTheUserSettings()
    When I click the New user button                                   # UsersSettingsContext::iClickTheNewUserButton()
      New user button in Users Settings could not be found (NoSuchElementException)
    And I see that the new user form is shown                          # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
    And I set the user name for the new user to "test"                 # UsersSettingsContext::iSetTheUserNameForTheNewUserTo()
    And I set the display name for the new user to "Test display name" # UsersSettingsContext::iSetTheDisplayNameForTheNewUserTo()
    And I set the password for the new user to "123456acb"             # UsersSettingsContext::iSetThePasswordForTheNewUserTo()
    And I create the new user                                          # UsersSettingsContext::iCreateTheNewUser()
    Then I see that the list of users contains the user "test"         # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()

MorrisJobke · 2020-10-25T21:32:13Z

#23680:

1) Test\Files\Storage\Wrapper\QuotaTest::testFreeSpaceWithUnknownDiskSpace
Failed asserting that -1 matches expected 6.

/drone/src/tests/lib/Files/Storage/Wrapper/QuotaTest.php:92

MorrisJobke · 2020-10-26T08:55:04Z

#23688:

1) Test\Share20\DefaultShareProviderTest::testDeleteGroupShareWithUserGroupShares
Failed asserting that an array is empty.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:581

MorrisJobke · 2020-10-26T21:49:29Z

#23693:

1) Test\Files\ObjectStore\ObjectStoreStorageTest::testFOpen with data set #4 ('spéciäl fäile')
stream_get_contents() expects parameter 1 to be resource, bool given

/drone/src/tests/lib/Files/Storage/Storage.php:385

MorrisJobke · 2020-10-27T08:10:30Z

#23700:

1) Test\Share20\DefaultShareProviderTest::testGetShareByIdUserShare
OCP\Share\Exceptions\ShareNotFound: There was an error retrieving the share. Maybe the link is wrong, it was unshared, or it was deleted.

/drone/src/lib/private/Share20/DefaultShareProvider.php:763
/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:220

MorrisJobke · 2020-10-27T09:31:43Z

#23705:

1) Test\TagsTest::testAddTags
add() returned an ID <= 0
Failed asserting that 0 is greater than 0.

/drone/src/tests/lib/TagsTest.php:100

MorrisJobke · 2020-10-27T09:31:54Z

#23705:

2) OCA\ShareByMail\Tests\ShareByMailProviderTest::testUserDeleted
Failed asserting that 543 is identical to 0.

/drone/src/apps/sharebymail/tests/ShareByMailProviderTest.php:869

MorrisJobke · 2020-10-27T10:14:40Z

#23710:

1) OCA\DAV\Tests\unit\Connector\Sabre\FileTest::testSimplePutNoCreatePermissions
TypeError: Argument 2 passed to OCA\DAV\Connector\Sabre\File::__construct() must implement interface OCP\Files\FileInfo, bool given, called in /drone/src/apps/dav/tests/unit/Connector/Sabre/FileTest.php on line 1192

/drone/src/apps/dav/lib/Connector/Sabre/File.php:86
/drone/src/apps/dav/tests/unit/Connector/Sabre/FileTest.php:1192

MorrisJobke · 2020-10-27T12:52:34Z

#23708:

1) Test\Comments\ManagerTest::testDeleteCommentsAtObject
InvalidArgumentException: IDs must be translatable to a number in this implementation.

/drone/src/lib/private/Comments/Manager.php:248
/drone/src/tests/lib/Comments/ManagerTest.php:664

MorrisJobke · 2020-10-28T07:25:05Z

#23728:

tests/acceptance/features/header.feature:42

  Scenario: just added users are seen in the contacts menu               # /drone/src/tests/acceptance/features/header.feature:42
    Given I am logged in as the admin                                    # LoginPageContext::iAmLoggedInAsTheAdmin()
    And I open the User settings                                         # SettingsMenuContext::iOpenTheUserSettings()
    And I click the New user button                                      # UsersSettingsContext::iClickTheNewUserButton()
      New user button in Users Settings could not be found (NoSuchElementException)
    And I see that the new user form is shown                            # UsersSettingsContext::iSeeThatTheNewUserFormIsShown()
    And I create user user1 with password 123456acb                      # UsersSettingsContext::iCreateUserWithPassword()
    And I see that the list of users contains the user user1             # UsersSettingsContext::iSeeThatTheListOfUsersContainsTheUser()
    When I open the Contacts menu                                        # ContactsMenuContext::iOpenTheContactsMenu()
    Then I see that the Contacts menu is shown                           # ContactsMenuContext::iSeeThatTheContactsMenuIsShown()
    And I see that the contact "user0" in the Contacts menu is shown     # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
    And I see that the contact "user1" in the Contacts menu is shown     # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsShown()
    And I see that the contact "admin" in the Contacts menu is not shown # ContactsMenuContext::iSeeThatTheContactInTheContactsMenuIsNotShown()

MorrisJobke · 2020-10-28T20:13:03Z

#23746:

1) Test\Share20\DefaultShareProviderTest::testUpdateLinkRemovePassword
Failed asserting that 0 matches expected 1.

/drone/src/tests/lib/Share20/DefaultShareProviderTest.php:1901

MorrisJobke · 2020-10-29T10:17:56Z

#23765:

1) Test\Files\Cache\CacheTest::testSearchQueryByTag
Failed asserting that 0 matches expected 3.

/drone/src/tests/lib/Files/Cache/CacheTest.php:363

PVince81 · 2020-10-30T08:16:45Z

Another weirdo:

1) OCA\OAuth2\Tests\Db\AccessTokenMapperTest::testGetByCode
Failed asserting that two objects are equal.
--- Expected
+++ Actual
@@ @@
     'clientId' => 1234
     'hashedCode' => 'e7e80c3a1768a280f6642f87eed76...40c0ef'
     'encryptedToken' => 'MyEncryptedToken'
-    'id' => 0
+    'id' => 1
     '_updatedFields' => Array ()
     '_fieldTypes' => Array (...)
 )

/drone/src/apps/oauth2/tests/Db/AccessTokenMapperTest.php:54

From #23782

MorrisJobke · 2020-11-03T09:28:08Z

#23842:

1) Test\Files\Node\FolderTest::testRecentFolder
Failed asserting that two arrays are equal.
--- Expected
+++ Actual
@@ @@
 Array (
-    0 => 0
+    0 => 1077
     1 => 1078
 )

/drone/src/tests/lib/Files/Node/FolderTest.php:903

MorrisJobke · 2020-11-09T14:42:22Z

#23994:

1) OCA\DAV\Tests\unit\Connector\Sabre\RequestTest\EncryptionMasterKeyUploadTest::testUploadOverWrite
TypeError: Argument 2 passed to OCA\DAV\Events\CalendarCreatedEvent::__construct() must be of the type array, null given, called in /drone/src/apps/dav/lib/CalDAV/CalDavBackend.php on line 790

/drone/src/apps/dav/lib/Events/CalendarCreatedEvent.php:51
/drone/src/apps/dav/lib/CalDAV/CalDavBackend.php:790
/drone/src/apps/dav/lib/HookManager.php:157
/drone/src/apps/dav/lib/AppInfo/Application.php:131
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:264
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:239
/drone/src/3rdparty/symfony/event-dispatcher/EventDispatcher.php:73
/drone/src/lib/private/EventDispatcher/SymfonyAdapter.php:85
/drone/src/lib/private/User/Session.php:569
/drone/src/lib/private/User/Session.php:415
/drone/src/lib/private/User/Session.php:624
/drone/src/lib/private/User/Session.php:367
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/Auth.php:84
/drone/src/3rdparty/sabre/dav/lib/DAV/Auth/Plugin.php:192
/drone/src/3rdparty/sabre/dav/lib/DAV/Auth/Plugin.php:144
/drone/src/3rdparty/sabre/event/lib/WildcardEmitterTrait.php:89
/drone/src/3rdparty/sabre/dav/lib/DAV/Server.php:458
/drone/src/3rdparty/sabre/dav/lib/DAV/Server.php:251
/drone/src/3rdparty/sabre/dav/lib/DAV/Server.php:319
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/RequestTestCase.php:134
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/RequestTestCase.php:116
/drone/src/apps/dav/tests/unit/Connector/Sabre/RequestTest/UploadTest.php:61

MorrisJobke · 2020-11-11T16:10:28Z

#24054:

1) Test\Repair\CleanTagsTest::testRun
Assert tag entries count after cleaning tag entries
Failed asserting that '1' matches expected 2.

/drone/src/tests/lib/Repair/CleanTagsTest.php:125
/drone/src/tests/lib/Repair/CleanTagsTest.php:92

MorrisJobke · 2020-11-11T16:10:48Z

#24054:

1) Test\User\DatabaseTest::testSearch
Failed asserting that actual size 3 matches expected size 2.

/drone/src/tests/lib/User/Backend.php:114
/drone/src/tests/lib/User/DatabaseTest.php:125

PVince81 · 2020-12-11T10:05:05Z

1) Test\Preview\BitmapTest::testGetThumbnail with data set #0 (-74, -53)
Failed asserting that null is not equal to false.

/drone/src/tests/lib/Preview/Provider.php:144
/drone/src/tests/lib/Preview/Provider.php:105

https://drone.nextcloud.com/nextcloud/server/325/13/5

from #24606

PVince81 · 2020-12-23T16:19:48Z

1) Test\Files\ViewTest::testRenameFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

2) Test\Files\ViewTest::testCopyFailDeleteTargetKeepSource
Trying to configure method "writeStream" which cannot be configured because it does not exist, has not been specified, is final, or is static

From #24829 (comment)
Drone: https://drone.nextcloud.com/nextcloud/server/687/15/5

MorrisJobke added bug help wanted 1. to develop Accepted and waiting to be taken care of technical debt labels Aug 19, 2020

MorrisJobke added this to the Nextcloud 20 milestone Aug 19, 2020

MorrisJobke mentioned this issue Aug 19, 2020

[stable19] fix moving files from external storage to object store trashbin #21983

Merged

MorrisJobke removed this from the Nextcloud 20 milestone Aug 20, 2020

MorrisJobke mentioned this issue Oct 12, 2020

VersioningTest.php:729 is unreliable and should be disabled #23396

Merged

MorrisJobke mentioned this issue Oct 15, 2020

Improve security & performance of Encrypt then MAC scheme. #23427

Closed

MorrisJobke mentioned this issue Oct 15, 2020

SharedMountTest.php:367 is unreliable #23492

Merged

MorrisJobke mentioned this issue Oct 22, 2020

Bring back the restore share button #23630

Merged

MorrisJobke mentioned this issue Oct 26, 2020

Clarify import cert command #23693

Merged

PVince81 mentioned this issue Dec 11, 2020

Add 'allow Symlinks' as an option to config.php #24606

Merged

PVince81 mentioned this issue Dec 23, 2020

Add migration for oc_share_external columns #24829

Merged

4 tasks

yan12125 mentioned this issue Jun 25, 2021

Correctly skip suppressed errors in PHP 8.0 #27631

Merged

szaimen removed the bug label Jan 23, 2023

joshtrichards added the tests Related to tests label Aug 24, 2023

Look into unstable tests #22305

Look into unstable tests #22305

Comments

MorrisJobke commented Aug 19, 2020 • edited

MorrisJobke commented Oct 13, 2020 • edited

MorrisJobke commented Oct 13, 2020 • edited

MorrisJobke commented Oct 13, 2020

MorrisJobke commented Oct 13, 2020

MorrisJobke commented Oct 13, 2020 • edited

MorrisJobke commented Oct 13, 2020 • edited

MorrisJobke commented Oct 13, 2020 • edited

MorrisJobke commented Oct 14, 2020 • edited

MorrisJobke commented Oct 14, 2020

MorrisJobke commented Oct 14, 2020 • edited by blizzz

MorrisJobke commented Oct 14, 2020

MorrisJobke commented Oct 14, 2020

MorrisJobke commented Oct 15, 2020 • edited

MorrisJobke commented Oct 15, 2020

MorrisJobke commented Oct 15, 2020

MorrisJobke commented Oct 15, 2020 • edited

MorrisJobke commented Oct 16, 2020

MorrisJobke commented Oct 16, 2020

MorrisJobke commented Oct 16, 2020

MorrisJobke commented Oct 16, 2020 • edited

MorrisJobke commented Oct 22, 2020

MorrisJobke commented Oct 22, 2020

MorrisJobke commented Oct 23, 2020

MorrisJobke commented Oct 23, 2020 • edited

MorrisJobke commented Oct 23, 2020

MorrisJobke commented Oct 25, 2020

MorrisJobke commented Oct 26, 2020

MorrisJobke commented Oct 26, 2020

MorrisJobke commented Oct 27, 2020

MorrisJobke commented Oct 27, 2020

MorrisJobke commented Oct 27, 2020

MorrisJobke commented Oct 27, 2020

MorrisJobke commented Oct 27, 2020

MorrisJobke commented Oct 28, 2020

MorrisJobke commented Oct 28, 2020

MorrisJobke commented Oct 29, 2020

PVince81 commented Oct 30, 2020

MorrisJobke commented Nov 3, 2020

MorrisJobke commented Nov 9, 2020

MorrisJobke commented Nov 11, 2020

MorrisJobke commented Nov 11, 2020

PVince81 commented Dec 11, 2020

PVince81 commented Dec 23, 2020

MorrisJobke commented Aug 19, 2020 •

edited

MorrisJobke commented Oct 13, 2020 •

edited

MorrisJobke commented Oct 13, 2020 •

edited

MorrisJobke commented Oct 13, 2020 •

edited

MorrisJobke commented Oct 13, 2020 •

edited

MorrisJobke commented Oct 13, 2020 •

edited

MorrisJobke commented Oct 14, 2020 •

edited

MorrisJobke commented Oct 14, 2020 •

edited by blizzz

MorrisJobke commented Oct 15, 2020 •

edited

MorrisJobke commented Oct 15, 2020 •

edited

MorrisJobke commented Oct 16, 2020 •

edited

MorrisJobke commented Oct 23, 2020 •

edited