Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unwanted dependency improve docs #236

Merged
merged 6 commits into from Dec 21, 2019
Merged

Remove unwanted dependency improve docs #236

merged 6 commits into from Dec 21, 2019

Conversation

jeffminsungkim
Copy link
Contributor

@jeffminsungkim jeffminsungkim commented Dec 20, 2019 •
edited

@jeffminsungkim jeffminsungkim mentioned this pull request Dec 20, 2019
Closed
4 tasks
@bashleigh
Copy link
Collaborator

Do you need to update dotenv or is it the correct version already? I'm guessing it is?

@bashleigh bashleigh self-requested a review December 20, 2019 11:22
@bashleigh bashleigh added the dependencies Pull requests that update a dependency file label Dec 20, 2019
@jeffminsungkim
Copy link
Contributor Author

jeffminsungkim commented Dec 20, 2019 •
edited

@bashleigh Good point! 😅 I forgot to remove @types/dotenv from devDependencies.

@jeffminsungkim
docs: users no longer need to install dotenv types
6b26d96 
- @types/dotenv removed from devDependencies and peerDependencies
- removed instruction from README
@jeffminsungkim
Merge branch 'remove-unwanted-dependency-improve-docs' of https://git…
0626a82 
…hub.com/jeffminsungkim/nestjs-config into remove-unwanted-dependency-improve-docs
@jeffminsungkim
Copy link
Contributor Author

jeffminsungkim commented Dec 20, 2019 •
edited

@bashleigh Now we're good to go 😄

@bashleigh bashleigh merged commit 5453a55 into nestjsx:master Dec 21, 2019
@bashleigh
Copy link
Collaborator

Thanks! :)

@jeffminsungkim jeffminsungkim deleted the remove-unwanted-dependency-improve-docs branch December 21, 2019 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bashleigh bashleigh bashleigh approved these changes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffminsungkim @bashleigh