Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@types/dotenv is no longer required to be installed by users #231

Closed
2 of 4 tasks
jeffminsungkim opened this issue Dec 19, 2019 · 2 comments
Closed
2 of 4 tasks

@types/dotenv is no longer required to be installed by users #231

jeffminsungkim opened this issue Dec 19, 2019 · 2 comments
Assignees
Labels
dependencies Pull requests that update a dependency file

Comments

@jeffminsungkim
Copy link
Contributor

Issue type:

  • question
  • bug report
  • feature request
  • documentation issue

nestjs-config version
1.4.5 (latest)

@nestjs/common+core or other package versions

  • @nestjs/common:
  • @nestjs/core:

Excepted behavior

Since Oct 16 dotenv package has added @types/dotenv. We no longer need to set the peerDependencies property in the package.json which shows unnecessary warning message, as well as the README file, should be fixed.

Actual behavior or outcome (for issue)

npm WARN nestjs-config@1.4.5 requires a peer of @types/dotenv@^8.2.0 but none is installed. You must install peer dependencies yourself.

Replication/Example

Better use dotenv types from the following path

node_modules/dotenv/types/index.d.ts

NOT

node_modules/nestjs-config/node_modules/dotenv/types/index.d.ts

Should I make a PR? 🤔

@bashleigh
Copy link
Collaborator

oooo yes please!

@bashleigh bashleigh added the dependencies Pull requests that update a dependency file label Dec 19, 2019
@jeffminsungkim
Copy link
Contributor Author

@bashleigh I've created the PR #236

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

No branches or pull requests

2 participants