Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unwanted dependency improve docs #236

Merged
merged 6 commits into from
Dec 21, 2019
Merged

Remove unwanted dependency improve docs #236

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
c0ff4b0
Added a new section in the doc
jeffminsungkim Aug 5, 2019
780d596
Merge branch 'improve-custom-env-file-path-doc'
jeffminsungkim Aug 7, 2019
83b7e10
Merge branch 'master' of https://github.com/nestjsx/nestjs-config
jeffminsungkim Dec 18, 2019
f275e85
docs: users no longer need to install dotenv types
jeffminsungkim Dec 20, 2019
6b26d96
docs: users no longer need to install dotenv types
jeffminsungkim Dec 20, 2019
0626a82
Merge branch 'remove-unwanted-dependency-improve-docs' of https://git…
jeffminsungkim Dec 20, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 1 addition & 7 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,13 +402,7 @@ export default {

## Custom env file path

To use dotenv options, you will need to install `@types/dotenv` by running

```bash
$ yarn add --dev @types/dotenv
```

Now you can specify dotenv options with the second parameter of the load method
You can specify dotenv options with the second parameter of the load method

```ts
ConfigModule.load(path.resolve(__dirname, '*/**!(*.d).config.{ts,js}'), {
Expand Down
4 changes: 1 addition & 3 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@
"prepublish": "npm run format && npm run build"
},
"peerDependencies": {
"@nestjs/common": "^5.1.0 || ^6.0.3",
"@types/dotenv": "^8.2.0"
"@nestjs/common": "^5.1.0 || ^6.0.3"
},
"dependencies": {
"dotenv": "^8.0.0",
Expand All @@ -53,7 +52,6 @@
"@nestjs/common": "^6.2.4",
"@nestjs/core": "^6.2.4",
"@nestjs/testing": "^6.2.4",
"@types/dotenv": "^8.2.0",
"@types/glob": "^7.1.1",
"@types/jest": "^24.0.11",
"coveralls": "^3.0.3",
Expand Down