馃悰 Fix HTML report sorting order storage in jQuery unload event #1066
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃悰 Fix HTML report sorting order storage in jQuery unload event.
This is related to: #986
I'm having a (probably) similar issue. In the generated HTML report, on the console, I'm seeing an error:
Using
$().unload
was deprecated and removed in jQuery 3. The recommendation is to use$().on("unload", handler)
.I see that it seems the included minified jQuery JS file says it has version 1.11: https://github.com/nedbat/coveragepy/blob/master/coverage/htmlfiles/jquery.min.js#L1
Nevertheless, when I generate an HTML report from scratch in a local project, the minified jQuery I get is indeed 3.x. I have no idea why.
Either way, the method with
$().on("unload", handler)
works with both versions.For completeness, I'm on Chrome, on Ubuntu.