Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chromium does not persist sorting order in HTML report #986

Closed
ptoews opened this issue May 10, 2020 · 4 comments
Closed

Chromium does not persist sorting order in HTML report #986

ptoews opened this issue May 10, 2020 · 4 comments
Labels
bug Something isn't working html

Comments

@ptoews
Copy link

ptoews commented May 10, 2020

Describe the bug
When sorting the coverage report by a column in Chromium, clicking on a module report and then going back results in the table being sorted by the default order (name) again.

To Reproduce

  1. What version of coverage.py are you using? The output of coverage debug sys is helpful
    5.1
  2. What commands did you run?
    coverage html -d tests/htmlcov

Chromium Version: 81.0.4044.122

Expected behavior
Sorting order is persisted after navigation

Additional context
Does work in Firefox. Maybe related to #611

@ptoews ptoews added the bug Something isn't working label May 10, 2020
@nedbat nedbat added the html label Jun 30, 2020
@nedbat
Copy link
Owner

nedbat commented Jun 30, 2020

The sorting is persisted in Chrome. Do you know what the difference is here between Chrome and Chromium?

@ptoews
Copy link
Author

ptoews commented Jun 30, 2020

No idea, but it might be something else.
Where is the sorting order supposed to be persisted? On the "Local Storage"? Because the Application Tab in the F12 menu doesn't show any values there.

@nedbat
Copy link
Owner

nedbat commented Dec 6, 2020

I can't be certain, but I think this is fixed with #1066. Let me know if the problem persists.

@nedbat nedbat closed this as completed Dec 6, 2020
@nedbat
Copy link
Owner

nedbat commented Dec 19, 2020

This is now released as part of coverage 5.3.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working html
Projects
None yet
Development

No branches or pull requests

2 participants