Apply fixes in #444 and #436 #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
mzgoddard
commented
Dec 9, 2018
•
mzgoddard
commented
- Fixes issue #443 by adding prefix to the HarmonyExportExpression model. #444
- fix: remove ExcludeMiniCssModulePlugin #436
As mini-css-extract-plugin pass `emitFile` to child compilation webpack-contrib/mini-css-extract-plugin@18c066e
mzgoddard
force-pushed
the
fix-things->_>
branch
from
e8564e6
to
f15bd9f
Compare
|
Life has been getting in my way of being to get this stuff in. Sorry. |
This was referenced Dec 9, 2018
|
no worries, thanks for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.