fix: remove ExcludeMiniCssModulePlugin #436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As mini-css-extract-plugin pass `emitFile` to child compilation webpack-contrib/mini-css-extract-plugin@18c066e
|
@mzgoddard hard to say way the test's are falling 😬 It would be awesome if you would add some section to README about contributing, basic describe your workflow when you are adding some futures... Current the whole test setup looks really complicated 😂would love to help with #342 Maybe it's time to lock webpack 1, 2, 3 to separate branches, and with master focus on newest version as webpack5 is around the corner... |
|
The reason the tests fail is the same as in my PR, it automatically installs latest webpack, which is incompatible with hard-source in a few cases, #446 |
|
Merged as part of #477 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mini-css-extract-plugin pass
emitFileto child compilationwebpack-contrib/mini-css-extract-plugin@18c066e