fix: remove ExcludeMiniCssModulePlugin

As mini-css-extract-plugin pass `emitFile` to child compilation webpack-contrib/mini-css-extract-plugin@18c066e
mzgoddard · Dec 9, 2018 · e8564e6 · e8564e6
1 parent 4dee389
commit e8564e6
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 49 deletions.
diff --git a/index.js b/index.js
@@ -433,10 +433,8 @@ class HardSourceWebpackPlugin {
     const TransformModuleErrorsPlugin = require('./lib/TransformModuleErrorsPlugin');
     const SupportExtractTextPlugin = require('./lib/SupportExtractTextPlugin');
     let SupportMiniCssExtractPlugin;
-    let ExcludeMiniCssModulePlugin;
     if (webpackFeatures.generator) {
       SupportMiniCssExtractPlugin = require('./lib/SupportMiniCssExtractPlugin');
-      ExcludeMiniCssModulePlugin = require('./lib/ExcludeMiniCssModulePlugin');
     }
     const TransformDependencyBlockPlugin = require('./lib/TransformDependencyBlockPlugin');
     const TransformBasicDependencyPlugin = require('./lib/TransformBasicDependencyPlugin');
@@ -479,7 +477,6 @@ class HardSourceWebpackPlugin {
 
     if (SupportMiniCssExtractPlugin) {
       new SupportMiniCssExtractPlugin().apply(compiler);
-      new ExcludeMiniCssModulePlugin().apply(compiler);
     }
 
     new TransformDependencyBlockPlugin({

diff --git a/lib/ExcludeMiniCssModulePlugin.js b/lib/ExcludeMiniCssModulePlugin.js
diff --git a/tests/plugins-webpack-4.js b/tests/plugins-webpack-4.js
@@ -19,7 +19,7 @@ describeWP(4)('plugin webpack 4 use', function() {
 
   itCompilesTwice.skipIf([c.miniCss])('plugin-mini-css-extract');
   itCompilesTwice.skipIf([c.miniCss])('plugin-mini-css-extract', {exportStats: true});
-  // itCompilesHardModules.skipIf([c.miniCss])('plugin-mini-css-extract', ['./index.css']);
+  itCompilesHardModules.skipIf([c.miniCss])('plugin-mini-css-extract', ['./index.css']);
 
   itCompilesTwice.skipIf([c.miniCss])('plugin-mini-css-extract-file');
   itCompilesTwice.skipIf([c.miniCss])('plugin-mini-css-extract-file', {exportStats: true});