Update setup.py to require Python 3.6+ #579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 13, 2021
|
Please consider merging this PR. We often need to rollback automatic updates of more-itertools as it breaks our CI with python 3.5 |
|
For the context, the breaking commit is ba5240a#diff-d7dff201bd69500a573b7e96c52f8e625242d769a04621224112faf6e7bc63fdR600. @bbayles could you merge this critical fix for the broken metadata and release this ASAP? The bug is causing a huge disruption in the CIs across the Python ecosystem. You'll also need to |
webknjaz
added a commit
to cherrypy/cheroot
that referenced
this pull request
Nov 23, 2021
`more-itertools` has a bug in their package metadata. They have dropped the testing of Python 3.5 from their CI but forgot to state this in the distribution package metadata. This is why we need these conditionals to work around the problem. Refs: * more-itertools/more-itertools#578 * more-itertools/more-itertools#579
bbayles
approved these changes
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue reference
#578
Changes
Bumps
python_requiresto '>=3.6'