Release 8.11 breaks compatibility with Python 3.5

[mattbonnell]

The new version makes use of f-strings, which were introduced in Python 3.6, making it incompatible with Python 3.5

File "<redacted>/.venv/lib/python3.5/site-packages/more_itertools/more.py", line 646

    f'Too few items in iterable (got {item_count})',

                                                  ^

SyntaxError: invalid syntax

[vfazio]

Note that 3.5 was dropped as of 8.6
https://github.com/more-itertools/more-itertools/blob/master/docs/versions.rst#860

as part of these PRs
#467
#469

[mattbonnell]

The python-requires param in the setup.py needs to be bumped to prevent 3.5 users from automatically pulling the new version which they are no longer compatible with.

Docs

[andy-maier]

@mattbonnell Right. The python-requires param is what pip evaluates. The classifiers are not evaluated by pip.

Circumvention for us was to exclude more-itertools 8.11.0 on Python 3.5 (see zhmcclient/python-zhmcclient#857).

[tysonite]

Can you remove release 8.11 on pypi? Or replace it with fixed version once #579 merged?

[webknjaz]

Oh, I was about to report the same issue. The runtime problem has been introduced in ba5240a#diff-d7dff201bd69500a573b7e96c52f8e625242d769a04621224112faf6e7bc63fdR600.

Instead of removing, I think it's okay if the maintainers use Yank, I think. These are the versions that need to be yanked: v8.11.2, v8.11.1, v8.11.0.

[webknjaz]

Cross-posting other incarnations of the same bug that has happened in the past: #272 + #355.

[bbayles]

Bad news: I can't remove the old PyPI release.

Better news, I hope: I'll drop the f-strings and ship a new version.

[bbayles]

8.12.0 is now on PyPI with the f-strings dropped and 3.5 back in setup.py. Hopefully this fixes everybody's CI systems.

Somehow my GitHub notifications for non-mentions got turned off for this repository; apologies for not seeing this until today.

[hwalinga]

Bad news: I can't remove the old PyPI release.

You should not remove it, but yank it instead:

https://www.python.org/dev/peps/pep-0592/

[bbayles]

I don't have the permissions on PyPI, I'm afraid.

[bbayles]

@erikrose, if you're available, could you yank 8.11.0 on PyPI?

.1 and .2 were GitHub-only releases for an unrelated RTD.

[erikrose]

Yanked! Happy Yanksgiving!