Set version limit on more-itertools in dev-requirements.txt #2795
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSchopmeyer
force-pushed
the
ks/fix-minimum-requirements-txt
branch
5 times, most recently
from
ccf6c52
to
f56b154
Compare
KSchopmeyer
force-pushed
the
ks/fix-minimum-requirements-txt
branch
from
f56b154
to
5799040
Compare
KSchopmeyer
changed the title
KSchopmeyer
force-pushed
the
ks/fix-minimum-requirements-txt
branch
from
5799040
to
08c3937
Compare
This was
linked to
issues
Nov 13, 2021
KSchopmeyer
added
priority
roll back needed
This was referenced Nov 13, 2021
andy-maier
reviewed
Nov 15, 2021
andy-maier
reviewed
Nov 15, 2021
to be == rather than <= as required for target definitions in minimum constraints. Somewhere I dropped the change from >= to == for the Sphinx target in minimum-requirements.txt.
KSchopmeyer
force-pushed
the
ks/fix-minimum-requirements-txt
branch
from
08c3937
to
9c77d47
Compare
andy-maier
approved these changes
Nov 15, 2021
andy-maier
added
roll back/forward done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #2796 that does not limit the version of more-itertools which causes test failures and fix an issue with use of >= in minimum-constraints.
This limits the version of more-itertools version 8.11.0 to python > 3.6
NOTE: I assume that the developers will correct the issue and either rerelease 8.11.0 or release an 8.11.1 since there is already a PR defined.
Priority because issue # 2796 it breaks tests.
Also fixes issue # 2792 where there is a invalid comparison error in minimum-constraints.txt. That, however, was not a test breaking issue.
NOTE: more-tools has a PR up to fix this problem (more-itertools/more-itertools#579) but if we assume that the fix in by creating a new version (several users have requested that they reissue 8.11.0) we will have another change to modify dev-requirements but this PR needed just to get our tests running again.
COMMENT: I marked this one for rollback but not sure it is really requredbecause:
NOTE: This also impacts pytest-easy-server since it uses pytest.