Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more-Itertools new version 8.11.0 causes test failures #2796

Closed
KSchopmeyer opened this issue Nov 12, 2021 · 0 comments · Fixed by #2795 or #2797
Closed

more-Itertools new version 8.11.0 causes test failures #2796

KSchopmeyer opened this issue Nov 12, 2021 · 0 comments · Fixed by #2795 or #2797
Assignees
Labels

Comments

@KSchopmeyer
Copy link
Collaborator

KSchopmeyer commented Nov 12, 2021

more-itertools Version 8.11.0 not does not support Python version < 3.6. Pywbem test failures include:

  1. Test failure for tests based on (python 3.5, macos and windows, latest). The test failure was:
    Fails in safety test:
    File "/Users/runner/hostedtoolcache/Python/3.5.10/x64/lib/python3.5/site-packages/more_itertools/init.py", line 1, in
    from .more import * # noqa
    File "/Users/runner/hostedtoolcache/Python/3.5.10/x64/lib/python3.5/site-packages/more_itertools/more.py", line 646
    f'Too few items in iterable (got {item_count})', ^
    SyntaxError: invalid syntax
    make: *** [test] Error 1
    Error: Process completed with exit code 2.

  2. test python 3.9, ubuntu, minimum:
    File "/opt/hostedtoolcache/Python/3.9.8/x64/lib/python3.9/site-packages/pyparsing/core.py", line 283, in wrapper
    ret = func(*args[limit:])
    File "/opt/hostedtoolcache/Python/3.9.8/x64/lib/python3.9/site-packages/packaging/requirements.py", line 61, in
    lambda s, l, t: Marker(s[t._original_start:t._original_end])
    TypeError: slice indices must be integers or None or have an index method
    make: *** [Makefile:843: safety_py3.9.done] Error 1
    Error: Process completed with exit code 2.

Proposed solution, limit maximum version of more-itertools for now until the issue is resolved within more-itertools

more-itertools is a dependency for pytest per pipdeptree

  • pytest [required: >=3.6, installed: 4.4.0]
    • atomicwrites [required: >=1.0, installed: 1.4.0]
    • attrs [required: >=17.4.0, installed: 21.2.0]
    • more-itertools [required: >=4.0.0, installed: 8.11.0]

NOTE: more_itertools stopped supporting python 2.7 with version 6.0.0 and that is documented in their setup

See more-itertools issue more-itertools/more-itertools#578 which requests that the limitation become part of the setup and more-itertools PR more-itertools/more-itertools#579 that defines the change to setup.

@KSchopmeyer KSchopmeyer self-assigned this Nov 12, 2021
@KSchopmeyer KSchopmeyer changed the title more-Iter tools new version 8.11.0 causes test failures more-Itertools new version 8.11.0 causes test failures Nov 13, 2021
KSchopmeyer added a commit that referenced this issue Nov 13, 2021
to be == rather than <= as required for target definitions in
minimum constraints.

Somewhere I dropped the change from >= to == for the Sphinx target in
minimum-requirements.txt.
KSchopmeyer added a commit that referenced this issue Nov 13, 2021
to be == rather than <= as required for target definitions in
minimum constraints.

Somewhere I dropped the change from >= to == for the Sphinx target in
minimum-requirements.txt.
KSchopmeyer added a commit that referenced this issue Nov 15, 2021
to be == rather than <= as required for target definitions in
minimum constraints.

Somewhere I dropped the change from >= to == for the Sphinx target in
minimum-requirements.txt.
andy-maier pushed a commit that referenced this issue Nov 15, 2021
to be == rather than <= as required for target definitions in
minimum constraints.

Somewhere I dropped the change from >= to == for the Sphinx target in
minimum-requirements.txt.
andy-maier pushed a commit that referenced this issue Nov 15, 2021
to be == rather than <= as required for target definitions in
minimum constraints.

Somewhere I dropped the change from >= to == for the Sphinx target in
minimum-requirements.txt.
andy-maier pushed a commit that referenced this issue Nov 15, 2021
to be == rather than <= as required for target definitions in
minimum constraints.

Somewhere I dropped the change from >= to == for the Sphinx target in
minimum-requirements.txt.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
1 participant