New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dispatcher: Give a couple of minutes for nodes to recover on re-election #1238
dispatcher: Give a couple of minutes for nodes to recover on re-election #1238
Conversation
Will fix moby/moby#25017 /cc @thaJeztah |
Seems reasonable as a stopgap. LGTM Let's file an issue about improving this, though. |
@aluzzardi Test failure on dispatcher, seems related 😕 (need to update the test to reflect the change I guess) |
Test is failing. I can reproduce the test failure locally. |
Yep. Damn, this is much bigger |
The tests hardcode a wait of 500 ms |
Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
56cc6d6
to
8b7de39
Compare
PTAL |
Current coverage is 54.89% (diff: 100%)@@ master #1238 diff @@
==========================================
Files 78 78
Lines 12403 12406 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 6817 6810 -7
- Misses 4651 4658 +7
- Partials 935 938 +3
|
LGTM |
/cc @LK4D4 @aaronlehmann
Signed-off-by: Andrea Luzzardi aluzzardi@gmail.com