Revert "dispatcher: Give a couple of minutes for nodes to recover on re-election" #1240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Needs Signed-off-by. |
|
Please sign your commits following these rules: $ git clone -b "revert-1238-dispatcher-unknown-extra-graceperiod" git@github.com:docker/swarmkit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmmending updates the existing PR. You DO NOT need to open a new one. |
aluzzardi
force-pushed
the
revert-1238-dispatcher-unknown-extra-graceperiod
branch
from
9bbf86f
to
be1b8bc
Compare
…re-election" Signed-off-by: Andrea Luzzardi <aluzzardi@gmail.com>
aluzzardi
force-pushed
the
revert-1238-dispatcher-unknown-extra-graceperiod
branch
from
be1b8bc
to
d4c4812
Compare
|
LGTM |
|
LGTM 😢 |
|
/cc @LK4D4 @thaJeztah Had to revert because of broken integration test and no easy fix. Will need something else for moby/moby#25017 |
aaronlehmann
deleted the
revert-1238-dispatcher-unknown-extra-graceperiod
branch
|
@aluzzardi yup, saw the discussion on slack; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #1238
Breaks docker/docker integration tests.