Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): bump jest-junit from 12.3.0 to 13.0.0 #4766

Merged
merged 3 commits into from Oct 25, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 4, 2021

Bumps jest-junit from 12.3.0 to 13.0.0.

Release notes

Sourced from jest-junit's releases.

v13.0.0

Update strip-ansi to newer version - jest-community/jest-junit#188 Add noStackTrace CLI option - jest-community/jest-junit#160 Fix rootDir usage - jest-community/jest-junit#154

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot requested a review from a team as a code owner October 4, 2021 18:05
@dependabot dependabot bot added category: engineering dependencies Pull requests that update a dependency file labels Oct 4, 2021
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 19, 2021

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@karanbirsingh karanbirsingh reopened this Oct 19, 2021
Bumps [jest-junit](https://github.com/jest-community/jest-junit) from 12.3.0 to 13.0.0.
- [Release notes](https://github.com/jest-community/jest-junit/releases)
- [Commits](jest-community/jest-junit@v12.3.0...v13.0.0)

---
updated-dependencies:
- dependency-name: jest-junit
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/jest-junit-13.0.0 branch from e1e9bc2 to 4772b52 Compare October 19, 2021 22:49
@karanbirsingh
Copy link
Contributor

karanbirsingh commented Oct 25, 2021

I believe our usage of outputDir and outputName is no longer compatible with the changes introduced in jest-community/jest-junit#154 in jest-junit - the builds all failed to produce test result files. This explicitly failed here and passed (when it should have failed) here.

I've updated our usage to qualify the directory in outputDir and leave outputName short. This matches our base jest config. You can see these builds have appropriate test result files:

We might be able to fail the test run if junit files are missing - this would have produced a more accurate status for the GitHub check runs that originally passed. Perhaps reporttestSuiteErrors from https://www.npmjs.com/package/jest-junit? I think we can pull that in separately.

The e2e-reliability builds had some failures - they seem unrelated to me; will requeue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: engineering dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants