Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adjust jest outputDirectory & outputName field #684

Merged
merged 1 commit into from Oct 28, 2021

Conversation

karanbirsingh
Copy link
Contributor

Details

This PR follows microsoft/accessibility-insights-web#4766 (comment) by ensuring any directory information in outputFile is moved to outputDirectory.

Motivation

make code consistent, head off potential issue described in microsoft/accessibility-insights-web#4766 (comment)

Pull request checklist

  • PR title respects Conventional Commits (starts with fix:, feat:, etc, and is suitable for user-facing release notes)
  • PR contains no breaking changes, OR description of both PR and final merge commit starts with BREAKING CHANGE:
  • (if applicable) Addresses issue: #0000
  • Added relevant unit tests for your changes
  • Ran yarn precheckin
  • Verified code coverage for the changes made

@karanbirsingh karanbirsingh requested a review from a team as a code owner October 27, 2021 23:27
Copy link
Contributor

@dbjorge dbjorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that junit.xml appears under /test-results/ as expected before/after manually updating jest-junit to v13

@karanbirsingh karanbirsingh merged commit 551f240 into main Oct 28, 2021
@karanbirsingh karanbirsingh deleted the karan/switch-jest-config branch October 28, 2021 17:01
@ada-cat
Copy link
Collaborator

ada-cat commented Apr 20, 2022

🎉 This PR is included in version 2.9.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants