Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adjust jest outputDirectory & outputName field #702

Merged
merged 2 commits into from Oct 28, 2021
Merged

chore: adjust jest outputDirectory & outputName field #702

merged 2 commits into from Oct 28, 2021

Conversation

karanbirsingh
Copy link
Contributor

Details

This PR follows microsoft/accessibility-insights-web#4766 (comment) by ensuring any directory information in outputFile is moved to outputDirectory.

Motivation

make code consistent, head off potential issue described in microsoft/accessibility-insights-web#4766 (comment)

Pull request checklist

  • If this PR addresses an existing issue, it is linked: Fixes #0000
  • New sample content is commented at a similar verbosity as existing content
  • All updated/modified sample code builds and runs in at least one PR/CI build
  • PR checks for builds named [failing example] ... fail as expected

@karanbirsingh karanbirsingh requested a review from a team as a code owner October 27, 2021 23:26
dbjorge
dbjorge approved these changes Oct 28, 2021
View reviewed changes
Copy link
Contributor

@dbjorge dbjorge left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified that junit.xml appears under /typescript-selenium-webdriver-sample/test-results/ as expected with jest-junit v13

@karanbirsingh karanbirsingh merged commit 2d5f08a into main Oct 28, 2021
@karanbirsingh karanbirsingh deleted the karan/adjust-jest-config branch October 28, 2021 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dbjorge dbjorge dbjorge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@karanbirsingh @dbjorge