eslint config: Fix modern module resolution

[tylerbutler]

Eslint's plugin behavior is to load the plugin relative to the current project. This means that if you have a shared config that depends on plugins, like we do, then each project using the shared config has to have the plugins defined as part of their own dependencies. The issue tracking this on the Eslint side is eslint/eslint#3458.

It's more convenient if the plugins are loaded relative to the shared config itself, rather than the project being linted. The Rush team provides a module that works around this behavior by patching eslint.

When I originally added the workaround package, I didn't understand how to use it properly. Now I do. Each inheriting config needs to have the following line at the beginning of their .eslintrc.js file:

// This is a workaround for https://github.com/eslint/eslint/issues/3458
require("@fluidframework/eslint-config-fluid/patch/modern-module-resolution");

That will load the patch module from the shared eslint config, which will make eslint load the plugins from the shared eslint config package. These changes will be in a future PR. This PR just updates the shared config itself.

Updating the config and publishing a new version is necessary to address this error that arises when adding the workaround:

ESLint couldn't determine the plugin "@typescript-eslint" uniquely.

- /workspaces/FluidFramework/common/lib/driver-definitions/node_modules/@rushstack/eslint-config/node_modules/@typescript-eslint/eslint-plugin/dist/index.js (loaded in ".eslintrc.js » @fluidframework/eslint-config-fluid » @rushstack/eslint-config/profile/web-app")
- /workspaces/FluidFramework/common/lib/driver-definitions/node_modules/@typescript-eslint/eslint-plugin/dist/index.js (loaded in ".eslintrc.js » @fluidframework/eslint-config-fluid » ./eslint7")

Please remove the "plugins" setting from either config or remove either plugin installation.

The error happens because the minimal config inherits from two configs that both use @typescript-eslint. This change stops extending the rushstack config, and instead depends directly on the plugins that the rushstack config itself uses.

[heliocliu]

ooo i like this