Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: Add dependency on eslint-plugin-jsdoc #10357

Merged
merged 14 commits into from
May 23, 2022
Merged

build: Add dependency on eslint-plugin-jsdoc #10357

merged 14 commits into from
May 23, 2022

Conversation

Josmithr
Copy link
Contributor

@Josmithr Josmithr commented May 19, 2022 •
edited

10317 - Add eslint-plugin-jsdoc to allow enforcement of source code docs style, and potentially enforce docs presence in the future

For more details on the package, see here.

This PR adds a dependency on the package so we can utilize its rules in the future.

@Josmithr Josmithr requested review from msfluid-bot and a team as code owners May 19, 2022 22:11
@Josmithr Josmithr linked an issue May 19, 2022 that may be closed by this pull request
Add eslint-plugin-jsdoc to allow enforcement of source code docs style, and potentially enforce docs presence in the future #10317
Closed
@Josmithr Josmithr self-assigned this May 19, 2022
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label May 19, 2022
@Josmithr Josmithr requested a review from tylerbutler May 19, 2022 22:11
@github-actions github-actions bot added the base: main PRs targeted against main branch label May 19, 2022
@Josmithr
merge: main into `10317-add-eslint-plugin-jsdoc-to-allow-enforcemen…
31b3191 
…t-of-source-code-docs-style-and-potentially-enforce-docs-presence-in-the-future`
@github-actions github-actions bot removed the dependencies Pull requests that update a dependency file label May 19, 2022
@Josmithr Josmithr marked this pull request as draft May 19, 2022 22:24
@Josmithr Josmithr marked this pull request as ready for review May 20, 2022 17:24
@Josmithr Josmithr requested a review from a team as a code owner May 20, 2022 17:24
@Josmithr
Merge branch 'main' into 10317-add-eslint-plugin-jsdoc-to-allow-enfor…
9b947cb 
…cement-of-source-code-docs-style-and-potentially-enforce-docs-presence-in-the-future
@Josmithr
build: Add dev dep to remaining packages
7adb22e
@Josmithr Josmithr requested review from a team as code owners May 21, 2022 00:35
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: definitions area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver labels May 21, 2022
@github-actions github-actions bot removed area: dds: propertydds area: examples Changes that focus on our examples area: runtime Runtime related issues area: dev experience Improving the experience of devs building on top of fluid area: server Server related issues (routerlicious) area: driver Driver related issues dependencies Pull requests that update a dependency file labels May 21, 2022
@github-actions github-actions bot added area: dds Issues related to distributed data structures area: dds: propertydds area: dds: sharedstring area: definitions area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: server Server related issues (routerlicious) area: tests Tests to add, test infrastructure improvements, etc dependencies Pull requests that update a dependency file labels May 21, 2022
@Josmithr Josmithr marked this pull request as ready for review May 21, 2022 01:42
@Josmithr Josmithr merged commit e59ca17 into microsoft:main May 23, 2022
@Josmithr Josmithr deleted the 10317-add-eslint-plugin-jsdoc-to-allow-enforcement-of-source-code-docs-style-and-potentially-enforce-docs-presence-in-the-future branch February 28, 2023 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tylerbutler tylerbutler tylerbutler approved these changes

@msfluid-bot msfluid-bot Awaiting requested review from msfluid-bot

Assignees

@Josmithr Josmithr

Labels
area: dds: propertydds area: dds: sharedstring area: dds Issues related to distributed data structures area: definitions area: dev experience Improving the experience of devs building on top of fluid area: driver Driver related issues area: examples Changes that focus on our examples area: framework Framework is a tag for issues involving the developer framework. Eg Aqueduct area: loader Loader related issues area: odsp-driver area: runtime Runtime related issues area: server Server related issues (routerlicious) area: tests Tests to add, test infrastructure improvements, etc base: main PRs targeted against main branch dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
2 participants
@Josmithr @tylerbutler