Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converted no-single-element-tuple-type from TSLint to ESLint #653

Merged

Conversation

JoshuaKGoldberg
Copy link
Contributor

Continues the work from #539. Ref: #648

Copy link
Member

@sandersn sandersn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

  1. I want to get a clean run before merging.
  2. This seems like another rule that might be generally useful.

create(context) {
return {
// eslint-disable-next-line @typescript-eslint/naming-convention
"TSTupleType[elementTypes.length=1]"(node: TSESTree.TSTupleType) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fancy!

@sandersn
Copy link
Member

OK, it's clean!

@sandersn sandersn merged commit 214c7bd into microsoft:master Mar 24, 2023
6 checks passed
@sandersn
Copy link
Member

Well, I messed up the test run and I don't know why, but the new rule finds a lot more single element tuple types than the old did.
I'm running DT (with the rule turned on this time) and will add exemptions to the packages that fail.

@JoshuaKGoldberg JoshuaKGoldberg deleted the no-single-element-tuple-type branch March 27, 2023 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants