Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Converted no-single-element-tuple-type from TSLint to ESLint (#653)
- Loading branch information
1 parent
f02f34c
commit 214c7bd
Showing
5 changed files
with
59 additions
and
43 deletions.
There are no files selected for viewing
31 changes: 31 additions & 0 deletions
31
packages/dtslint/src/rules/no-single-element-tuple-type.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,31 @@ | ||
import { createRule } from "../util"; | ||
import { TSESTree } from "@typescript-eslint/utils"; | ||
|
||
const rule = createRule({ | ||
name: "no-single-element-tuple-type", | ||
defaultOptions: [], | ||
meta: { | ||
type: "problem", | ||
docs: { | ||
description: "Forbids `[T]`, which should be `T[]`.", | ||
recommended: "error", | ||
}, | ||
messages: { | ||
singleElementTupleType: `Type [T] is a single-element tuple type. You probably meant T[].`, | ||
}, | ||
schema: [], | ||
}, | ||
create(context) { | ||
return { | ||
// eslint-disable-next-line @typescript-eslint/naming-convention | ||
"TSTupleType[elementTypes.length=1]"(node: TSESTree.TSTupleType) { | ||
context.report({ | ||
messageId: "singleElementTupleType", | ||
node, | ||
}); | ||
}, | ||
}; | ||
}, | ||
}); | ||
|
||
export = rule; |
32 changes: 0 additions & 32 deletions
32
packages/dtslint/src/rules/noSingleElementTupleTypeRule.ts
This file was deleted.
Oops, something went wrong.
28 changes: 28 additions & 0 deletions
28
packages/dtslint/test/no-single-element-tuple-type.test.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
import { ESLintUtils } from "@typescript-eslint/utils"; | ||
|
||
import * as noDeclareCurrentPackage from "../src/rules/no-single-element-tuple-type"; | ||
|
||
const ruleTester = new ESLintUtils.RuleTester({ | ||
parser: "@typescript-eslint/parser", | ||
}); | ||
|
||
ruleTester.run("no-single-element-tuple-type", noDeclareCurrentPackage, { | ||
invalid: [ | ||
{ | ||
code: `type Test<T> = [T];`, | ||
errors: [ | ||
{ | ||
line: 1, | ||
messageId: "singleElementTupleType", | ||
}, | ||
], | ||
}, | ||
], | ||
valid: [ | ||
`type Test = number[];`, | ||
`type Test<T> = T;`, | ||
`type Test<T> = T[];`, | ||
`type Test<T> = [T, number];`, | ||
`type Test<T> = [T, T];`, | ||
], | ||
}); |
5 changes: 0 additions & 5 deletions
5
packages/dtslint/test/no-single-element-tuple-type/test.ts.lint
This file was deleted.
Oops, something went wrong.
6 changes: 0 additions & 6 deletions
6
packages/dtslint/test/no-single-element-tuple-type/tslint.json
This file was deleted.
Oops, something went wrong.