New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converted no-single-declare-module from TSLint to ESLint #655
Converted no-single-declare-module from TSLint to ESLint #655
Conversation
|
||
import { createRule } from "../util"; | ||
|
||
const rule = createRule({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Obligatory reminder to add this to the preset (tell me if you already know and I'll stop mentioning it in the future 😄)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, every single reminder is helpful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is basically ready to go except that a local run is running out of memory much more often than before (it was 0 times before). I'm not sure what's going on; I need to test a version of this without the PR to make sure it isn't some other change.
I wonder whether it's possible that inspecting the sourcefile for module declarations and then converting that node back into the error-node somehow leaks the sourcefile node.
Happens on master too. I'll merge and ship this in the morning. |
Requires microsoft/DefinitelyTyped-tools#655 to ship before it will pass tests.
Actually, uhhh, it's running out of memory on the initial I checked the overnight run and on-demand test runs from yesterday, and no problems. I suspect this is to do with the use of TS ASTs though, now that there are two of them in the pipeline. Or it could be the number of eslint rules all up, and adding two more has pushed some leak over the edge. |
I'm going to try rewriting this rule to use the eslint tree and look generally eslinty, and see if that helps the problem. |
Requires microsoft/DefinitelyTyped-tools#655 to ship before it will pass tests.
Continues the work from #653. Ref: #648