Add workbox-build to allowed packages
#581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current `workbox-build` typing reference inside the [@types/next-pwa](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/master/types/next-pwa) package points to `@types/workbox-build`, which has not updated its definitions since `v5.0` of the parent module. Currently, the original `workbox-build` package sits at `v6.5.4`. This package version mismatch may compromise the extended [webpackConfigOptions](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/next-pwa/index.d.ts#L44) type referenced within the `@types/next-pwa` package. To solve this issue, adding the dependency to the allowed packages list will ensure that the reference won't ripple any **possibly** stale and/or mismatched types. ###### BTW, to further reiterate the issue, see the current workaround to the [mismatched types](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/types/next-pwa/index.d.ts#L11-L16).
NivaldoFarias
requested review from
sandersn and
andrewbranch
as code owners
sandersn
approved these changes
Dec 20, 2022
This was referenced Dec 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
workbox-buildtyping reference inside the @types/next-pwa package points to@types/workbox-build, which has not updated its definitions sincev5.0of the parent module. Currently, the originalworkbox-buildpackage sits atv6.5.4. This package version mismatch may compromise the extended webpackConfigOptions type referenced within the@types/next-pwapackage.To solve this issue, adding the dependency to the allowed packages list will ensure that the reference won't ripple any possibly stale and/or mismatched types.
BTW, to further reiterate the issue, see the current workaround to the mismatched types.