Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove multiple workbox-_ DT packages, resolve versions mismatch #63682

Merged
merged 25 commits into from Jan 2, 2023

Conversation

NivaldoFarias
Copy link
Contributor

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: allowed packages PR
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the header.

@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 20, 2022

@NivaldoFarias Thank you for submitting this PR!

This is a live comment which I will keep updated.

This PR touches some part of DefinitelyTyped infrastructure, so a DT maintainer will need to review it. This is rare — did you mean to do this?

18 packages in this PR (and infra files)

Code Reviews

Because this PR edits multiple packages, it can be merged once it's reviewed by a DT maintainer.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ A DT maintainer needs to approve changes which affect DT infrastructure (notNeededPackages.json)

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 63682,
  "author": "NivaldoFarias",
  "headCommitOid": "2ffa505bca903a9ff59e1da4d4d990e9d677b7d5",
  "mergeBaseOid": "dc9b44bf728c2c49f22055ddf0dec39d74ce2722",
  "lastPushDate": "2023-01-02T13:40:04.000Z",
  "lastActivityDate": "2023-01-02T20:14:23.000Z",
  "mergeOfferDate": "2023-01-02T20:10:37.000Z",
  "mergeRequestDate": "2023-01-02T20:14:23.000Z",
  "mergeRequestUser": "NivaldoFarias",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Well-liked by everyone",
  "pkgInfo": [
    {
      "name": null,
      "kind": "edit",
      "files": [
        {
          "path": "notNeededPackages.json",
          "kind": "infrastructure"
        }
      ],
      "owners": [],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    },
    {
      "name": "customize-cra",
      "kind": "edit",
      "files": [
        {
          "path": "types/customize-cra/customize-cra-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/customize-cra/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "k-yle"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "next-pwa",
      "kind": "edit",
      "files": [
        {
          "path": "types/next-pwa/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/next-pwa/next-pwa-tests.ts",
          "kind": "test"
        },
        {
          "path": "types/next-pwa/package.json",
          "kind": "package-meta-ok"
        }
      ],
      "owners": [
        "NivaldoFarias"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "workbox-background-sync",
      "kind": "delete",
      "files": [
        {
          "path": "types/workbox-background-sync/Plugin.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-background-sync/Queue.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-background-sync/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-background-sync/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-background-sync/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-background-sync/workbox-background-sync-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "JasonHK"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "workbox-broadcast-update",
      "kind": "delete",
      "files": [
        {
          "path": "types/workbox-broadcast-update/BroadcastCacheUpdate.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-broadcast-update/Plugin.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-broadcast-update/broadcastUpdate.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-broadcast-update/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-broadcast-update/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-broadcast-update/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-broadcast-update/workbox-broadcast-update-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "JasonHK"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "workbox-build",
      "kind": "delete",
      "files": [
        {
          "path": "types/workbox-build/_types.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-build/generate-sw.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-build/get-manifest.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-build/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-build/inject-manifest.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-build/lib/copy-workbox-libraries.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-build/lib/get-module-url.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-build/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-build/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-build/workbox-build-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "prichey"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "workbox-cacheable-response",
      "kind": "delete",
      "files": [
        {
          "path": "types/workbox-cacheable-response/CacheableResponse.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-cacheable-response/Plugin.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-cacheable-response/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-cacheable-response/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-cacheable-response/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-cacheable-response/workbox-cacheable-response-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "JasonHK"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "workbox-core",
      "kind": "delete",
      "files": [
        {
          "path": "types/workbox-core/cacheNames.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-core/clientsClaim.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-core/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-core/registerQuotaErrorCallback.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-core/setCacheNameDetails.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-core/skipWaiting.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-core/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-core/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-core/types/WorkboxPlugin.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-core/workbox-core-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "JasonHK"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "workbox-expiration",
      "kind": "delete",
      "files": [
        {
          "path": "types/workbox-expiration/CacheExpiration.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-expiration/Plugin.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-expiration/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-expiration/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-expiration/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-expiration/workbox-expiration-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "JasonHK"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "workbox-google-analytics",
      "kind": "delete",
      "files": [
        {
          "path": "types/workbox-google-analytics/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-google-analytics/initialize.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-google-analytics/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-google-analytics/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-google-analytics/workbox-google-analytics-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "JasonHK"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "workbox-navigation-preload",
      "kind": "delete",
      "files": [
        {
          "path": "types/workbox-navigation-preload/disable.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-navigation-preload/enable.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-navigation-preload/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-navigation-preload/isSupported.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-navigation-preload/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-navigation-preload/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-navigation-preload/workbox-navigation-preload-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "JasonHK"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "workbox-precaching",
      "kind": "delete",
      "files": [
        {
          "path": "types/workbox-precaching/PrecacheController.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-precaching/addPlugins.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-precaching/addRoute.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-precaching/cleanupOutdatedCaches.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-precaching/getCacheKeyForURL.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-precaching/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-precaching/precache.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-precaching/precacheAndRoute.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-precaching/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-precaching/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-precaching/types/CleanupResult.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-precaching/types/FetchListenerOptions.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-precaching/types/InstallResult.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-precaching/types/PrecacheEntry.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-precaching/types/URLManipulation.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-precaching/workbox-precaching-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "JasonHK"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "workbox-range-requests",
      "kind": "delete",
      "files": [
        {
          "path": "types/workbox-range-requests/Plugin.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-range-requests/createPartialResponse.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-range-requests/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-range-requests/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-range-requests/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-range-requests/workbox-range-requests-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "JasonHK"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "workbox-routing",
      "kind": "delete",
      "files": [
        {
          "path": "types/workbox-routing/NavigationRoute.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-routing/RegExpRoute.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-routing/Route.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-routing/Router.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-routing/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-routing/registerNavigationRoute.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-routing/registerRoute.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-routing/setCatchHandler.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-routing/setDefaultHandler.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-routing/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-routing/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-routing/types/HTTPMethod.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-routing/types/RouteHandler.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-routing/types/RouteMatchCallback.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-routing/workbox-routing-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "JasonHK"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "workbox-strategies",
      "kind": "delete",
      "files": [
        {
          "path": "types/workbox-strategies/CacheFirst.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-strategies/CacheOnly.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-strategies/NetworkFirst.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-strategies/NetworkOnly.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-strategies/StaleWhileRevalidate.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-strategies/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-strategies/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-strategies/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-strategies/types/MakeRequestCallback.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-strategies/workbox-strategies-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "JasonHK"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "workbox-streams",
      "kind": "delete",
      "files": [
        {
          "path": "types/workbox-streams/concatenate.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-streams/concatenateToResponse.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-streams/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-streams/isSupported.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-streams/strategy.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-streams/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-streams/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-streams/types/StreamSource.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-streams/workbox-streams-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "JasonHK"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "workbox-sw",
      "kind": "edit",
      "files": [
        {
          "path": "types/workbox-sw/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-sw/package.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-sw/workbox-sw-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "wessberg",
        "JasonHK"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "workbox-webpack-plugin",
      "kind": "delete",
      "files": [
        {
          "path": "types/workbox-webpack-plugin/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-webpack-plugin/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-webpack-plugin/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-webpack-plugin/v3/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-webpack-plugin/v3/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-webpack-plugin/v3/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-webpack-plugin/workbox-webpack-plugin-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "kgroat",
        "peterblazejewicz"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    },
    {
      "name": "workbox-window",
      "kind": "delete",
      "files": [
        {
          "path": "types/workbox-window/Workbox.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-window/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-window/messageSW.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-window/tsconfig.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-window/tslint.json",
          "kind": "package-meta-ok"
        },
        {
          "path": "types/workbox-window/types/WorkboxEvent.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-window/types/WorkboxEventMap.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-window/utils/EventTargetShim.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/workbox-window/workbox-window-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "ykzts",
        "JasonHK"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Well-liked by everyone"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "peterblazejewicz",
      "date": "2023-01-02T20:09:28.000Z",
      "isMaintainer": true
    }
  ],
  "mainBotCommentID": 1359763718,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Author is Owner The author of this PR is a listed owner of the package. No Other Owners This DT module only has one owner, so we can't have someone verify the change. Untested Change This PR does not touch tests labels Dec 20, 2022
@typescript-bot typescript-bot added this to Waiting for Code Reviews in New Pull Request Status Board Dec 20, 2022
@typescript-bot
Copy link
Contributor

🔔 @NivaldoFarias — you're the only owner, but it would still be good if you find someone to review this PR in the next few days, otherwise a maintainer will look at it. (And if you do find someone, maybe even recruit them to be a second owner to make future changes easier...)

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Dec 20, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Dec 20, 2022
@typescript-bot
Copy link
Contributor

@NivaldoFarias The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed The CI failed When GH Actions fails Untested Change This PR does not touch tests labels Dec 20, 2022
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Dec 20, 2022
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Dec 20, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Dec 20, 2022
@typescript-bot
Copy link
Contributor

@NivaldoFarias The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot added Edits Infrastructure Edits multiple packages and removed Author is Owner The author of this PR is a listed owner of the package. The CI failed When GH Actions fails No Other Owners This DT module only has one owner, so we can't have someone verify the change. labels Dec 20, 2022
@typescript-bot
Copy link
Contributor

typescript-bot commented Dec 20, 2022

🔔 @k-yle @JasonHK @prichey @wessberg @kgroat @peterblazejewicz @ykzts — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Dec 20, 2022
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Dec 20, 2022
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Dec 20, 2022
@typescript-bot
Copy link
Contributor

@NivaldoFarias The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Dec 20, 2022
@typescript-bot
Copy link
Contributor

@NivaldoFarias The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Dec 30, 2022
@typescript-bot
Copy link
Contributor

@NivaldoFarias The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Dec 30, 2022
@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Jan 2, 2023
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Jan 2, 2023
@typescript-bot typescript-bot added the The CI failed When GH Actions fails label Jan 2, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Author Action in New Pull Request Status Board Jan 2, 2023
@typescript-bot
Copy link
Contributor

@NivaldoFarias The CI build failed! Please review the logs for more information.

Once you've pushed the fixes, the build will automatically re-run. Thanks!

Note: builds which are failing do not end up on the list of PRs for the DT maintainers to review.

@typescript-bot typescript-bot removed the The CI failed When GH Actions fails label Jan 2, 2023
@typescript-bot typescript-bot moved this from Needs Author Action to Waiting for Code Reviews in New Pull Request Status Board Jan 2, 2023
@typescript-bot typescript-bot moved this from Waiting for Code Reviews to Needs Maintainer Action in New Pull Request Status Board Jan 2, 2023
@typescript-bot
Copy link
Contributor

@peterblazejewicz Thank you for reviewing this PR! The author has pushed new commits since your last review. Could you take another look and submit a fresh review?

@NivaldoFarias NivaldoFarias changed the title [next-pwa]: remove multiple workbox-_ DT packages, resolve versions mismatch remove multiple workbox-_ DT packages, resolve versions mismatch Jan 2, 2023
Copy link
Member

@peterblazejewicz peterblazejewicz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
@NivaldoFarias thanks!

@typescript-bot typescript-bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Jan 2, 2023
@typescript-bot
Copy link
Contributor

@NivaldoFarias: Everything looks good here. I am ready to merge this PR (at 2ffa505) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

@typescript-bot typescript-bot moved this from Needs Maintainer Action to Waiting for Author to Merge in New Pull Request Status Board Jan 2, 2023
@NivaldoFarias
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot moved this from Waiting for Author to Merge to Recently Merged in New Pull Request Status Board Jan 2, 2023
@typescript-bot typescript-bot merged commit 1dcd97e into DefinitelyTyped:master Jan 2, 2023
@typescript-bot typescript-bot removed this from Recently Merged in New Pull Request Status Board Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Edits Infrastructure Edits multiple packages Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants