Release 2.3.5 #11580
Merged
Release 2.3.5 #11580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The issue with babel-parser is fixed in this PR, I just tested it. Thank you! |
| @@ -40,7 +40,7 @@ Tinytest.add("ecmascript - transpilation - class methods", (test) => { | |||
| test.isTrue(contains(output, 'Foo.staticMethod = function staticMethod(')); | |||
| test.isTrue(contains(output, | |||
| '.prototypeMethod = function prototypeMethod(')); | |||
| test.isTrue(contains(output, '[computedMethod] = function (')); | |||
| test.isTrue(contains(output, '[_computedMethod] = function (')); | |||
There was a problem hiding this comment.
Was this just breaking tests and not actual code?
There was a problem hiding this comment.
As far as I can see yes. I will look if I can find something relevant in the changelogs, but from what I have been running the code and other tests there weren't any adverse effects.
🤔 Not even as far as I have tested in production build.
|
@Gywem rc.0 is out with new Node! |
filipenevola
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Help us test the upcoming release:
This release includes:
typescriptto version4.3.5for meteor2.4because it fixes a critical typescript bug #11566