Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade typescript to version 4.3.5 for meteor 2.4 because it fixes a critical typescript bug #11566

Closed
scharf opened this issue Aug 2, 2021 · 5 comments · Fixed by #11488, #11581 or #11580
Closed

Upgrade typescript to version 4.3.5 for meteor 2.4 because it fixes a critical typescript bug #11566

scharf opened this issue Aug 2, 2021 · 5 comments · Fixed by #11488, #11581 or #11580
Labels
confirmed We want to fix or implement it Project:JS Environment:Typescript
Milestone
Release 2.2.3

Comments

@scharf
Copy link
Contributor

scharf commented Aug 2, 2021

Typescript 4.3.3 fixes a breaking changes microsoft/TypeScript#44429

See also the description of release typescript 4.3.3 and follow the fixed issues query for TypeScript v4.3.3.

Therefore it would be great to update at least to typescript 4.3.3
@StorytellerCZ StorytellerCZ added this to the Release 2.4 milestone Aug 3, 2021
@StorytellerCZ StorytellerCZ added the confirmed We want to fix or implement it label Aug 3, 2021
@StorytellerCZ
Copy link
Collaborator

I think we still have the space for it in 2.4.

@StorytellerCZ
Copy link
Collaborator

@afrokick, @scharf would you be willing to do a PR or should I?

@StorytellerCZ
Copy link
Collaborator

Nevermind, already on it as I was going for the same files with another issue.

@StorytellerCZ StorytellerCZ linked a pull request Aug 3, 2021 that will close this issue
Release 2.4 #11488
Merged
4 tasks
@StorytellerCZ
Copy link
Collaborator

Typescript is updated in the latest 2.4 beta. Please give it a try.

@StorytellerCZ
Copy link
Collaborator

I will backport this to the Meteor 2.3.5 release so that we can get it sooner.

@StorytellerCZ StorytellerCZ mentioned this issue Aug 11, 2021
Merged
This was linked to pull requests Aug 11, 2021
Release 2.2.3 #11581
Merged
Release 2.3.5 #11580
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
confirmed We want to fix or implement it Project:JS Environment:Typescript
Projects
None yet
Milestone
Release 2.2.3
Development

Successfully merging a pull request may close this issue.

Release 2.4 meteor/meteor
Release 2.2.3 meteor/meteor
Release 2.3.5 meteor/meteor
2 participants
@StorytellerCZ @scharf