Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sourcemaps broken in VSCode #11583

Closed
Beretta1979 opened this issue Aug 11, 2021 · 1 comment · Fixed by #11584 or #11580
Closed

Sourcemaps broken in VSCode #11583

Beretta1979 opened this issue Aug 11, 2021 · 1 comment · Fixed by #11584 or #11580
Milestone

Comments

@Beretta1979
Copy link
Contributor

Beretta1979 commented Aug 11, 2021

OS: Ubuntu 20.04
This occurs in Meteor 2.3.4, in Meteor 2.2.1 everything was working fine

The sourcemaps are not working anymore, the breakpoints are not getting hit.
The issue is introduced by this PR: #11013. If the changes of this PR are reverted everything is working fine.

This is my launch.json file:

{
  "configurations": 
  [ 
    {
      "name": "Launch Meteor server",
      "request": "launch",
      "type": "node",
      "restart": true,
      "port": 9229,
      "cwd": "${workspaceFolder}/projects/test",
      "runtimeExecutable": "npm",
      "runtimeArgs": ["run", "start:debug"],
      "outputCapture": "std",
      "console": "integratedTerminal",
			"sourceMapPathOverrides": {
                          "meteor://💻app/*": "${workspaceFolder}/projects/test/*",
			},
    }
  ]
}
@Beretta1979
Copy link
Contributor Author

I think that in tools/isobuild/bundler.js, process.env.ROOT_URL should never be added for base64 encoded source mapping URLs

Beretta1979 added a commit to Beretta1979/meteor that referenced this issue Aug 12, 2021
Do not add ROOT_URLto sourceMappingURL for base64 encoded urls
StorytellerCZ added a commit that referenced this issue Aug 12, 2021
…_URL-to-sourceMappingURL-for-base64-encoded-urls

Fixes #11583 Do not add ROOT_URL to sourceMappingURL for base64 encoded urls
@StorytellerCZ StorytellerCZ linked a pull request Aug 12, 2021 that will close this issue
@StorytellerCZ StorytellerCZ added this to the Release 2.3.5 milestone Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants