Make the metallb rbac namespaced for the metallb CRs #1287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fedepaol
changed the title
fedepaol
force-pushed
the
namespacedcrds
branch
from
7c95d4f
to
cdc1152
Compare
fedepaol
force-pushed
the
namespacedcrds
branch
2 times, most recently
from
c0b0aa8
to
7c4d49d
Compare
|
/lgtm |
controller-gen is meant to generate rbac for one single role, while we have different rbacs for the controller and for the speaker. We remove the annotations and the generater rbac. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
By doing this, we can keep the role as namespace scoped instead of cluster scoped, limiting the namespace we listen for crs. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
The CRs are supposed to be created in the metallb's namespace, there's no need to create them cluster scoped. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Aligning the helm chart to have the crs namespaced instead of cluster scoped. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
Regenerated manifests with moving the rbac from cluster to namespace for the metallb CRs. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
We don't have the configmap anymore, we remove the role from the charts. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
The predicate is not needed anymore, as the crds are now namespaced and metallb listens only to those in its namespace. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
fedepaol
force-pushed
the
namespacedcrds
branch
from
0a01931
to
2846085
Compare
We bumped ci but we did not bump go.mod, aligning it. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
We update the version, and we wait more for it to complete. Also, changing the nolint annotation to be compatible to the new version. Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is based off #1275 as we need the new controller-runtime
that implements kubernetes-sigs/controller-runtime#1435 and kubernetes-sigs/controller-runtime#1602
Setting a namespace selector for all the crds allow the controllers to be namespace scoped for those, while being cluster scoped for all the other resources we need metallb to be cluster scoped to (nodes, services, etc).