Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the metallb rbac namespaced for the metallb CRs #1287

Merged
merged 9 commits into from
Mar 31, 2022
Merged

Make the metallb rbac namespaced for the metallb CRs #1287

merged 9 commits into from
Mar 31, 2022

Commits on Mar 31, 2022

  1. Rbac: remove the kustomize annotations 

    controller-gen is meant to generate rbac for one single role, while we
have different rbacs for the controller and for the speaker. We remove
the annotations and the generater rbac.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
    @fedepaol
    fedepaol committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    d71e034 View commit details
    Browse the repository at this point in the history

  2. Controllers: set a namespace selector on metallb crs 

    By doing this, we can keep the role as namespace scoped instead of
cluster scoped, limiting the namespace we listen for crs.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
    @fedepaol
    fedepaol committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    19aa044 View commit details
    Browse the repository at this point in the history

  3. Manifests: move the rbac from cluster to namespace for metallb crs 

    The CRs are supposed to be created in the metallb's namespace, there's
no need to create them cluster scoped.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
    @fedepaol
    fedepaol committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    9c1c6a4 View commit details
    Browse the repository at this point in the history

  4. Helm: move the rbac from cluster to namespace for crs 

    Aligning the helm chart to have the crs namespaced instead of cluster
scoped.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
    @fedepaol
    fedepaol committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    ce82cd8 View commit details
    Browse the repository at this point in the history

  5. Manifests: align with the new rbac 

    Regenerated manifests with moving the rbac from cluster to namespace for
the metallb CRs.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
    @fedepaol
    fedepaol committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    c0f9b88 View commit details
    Browse the repository at this point in the history

  6. Helm: remove unused config-watcher role 

    We don't have the configmap anymore, we remove the role from the charts.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
    @fedepaol
    fedepaol committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    070ddf5 View commit details
    Browse the repository at this point in the history

  7. Remove the predicate for namespace in config crds 

    The predicate is not needed anymore, as the crds are now namespaced and
metallb listens only to those in its namespace.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
    @fedepaol
    fedepaol committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    2846085 View commit details
    Browse the repository at this point in the history

  8. Bump go.mod to 1.17 

    We bumped ci but we did not bump go.mod, aligning it.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
    @fedepaol
    fedepaol committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    67b5e84 View commit details
    Browse the repository at this point in the history

  9. Bump golangci-lint and make the timeout longer 

    We update the version, and we wait more for it to complete.
Also, changing the nolint annotation to be compatible to the new
version.

Signed-off-by: Federico Paolinelli <fpaoline@redhat.com>
    @fedepaol
    fedepaol committed Mar 31, 2022
    Configuration menu
    Copy the full SHA
    cb9983e View commit details
    Browse the repository at this point in the history