Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump github.com/layer5io/meshkit from 0.2.29 to 0.2.30 #207

Merged
merged 9 commits into from Oct 18, 2021
Merged

Bump github.com/layer5io/meshkit from 0.2.29 to 0.2.30 #207

merged 9 commits into from Oct 18, 2021

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 10, 2021

Bumps github.com/layer5io/meshkit from 0.2.29 to 0.2.30.

Release notes

Sourced from github.com/layer5io/meshkit's releases.

MeshKit v0.2.30

What's New

Contributors

Thank you to our contributors for making this release possible: @​Revolyssup, @​leecalcote, @​piyushsingariya and @​utkarsh-pro

Commits
  • a18e452 Merge pull request #117 from utkarsh-pro/utkarsh-pro/fix/component-generator-...
  • 5d09dd2 change metadata keys to comply with the specification
  • 7e6ee2e Merge pull request #113 from Revolyssup/master
  • f0e5782 Merge pull request #115 from piyushsingariya/fix/singariya/minor-1
  • 0f96a6f minor fix in the logic
  • 0378821 added few extra checks to avoid panic
  • 7a7188a added few extra checks to avoid panic
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot
Bump github.com/layer5io/meshkit from 0.2.29 to 0.2.30
0d23d4f 
Bumps [github.com/layer5io/meshkit](https://github.com/layer5io/meshkit) from 0.2.29 to 0.2.30.
- [Release notes](https://github.com/layer5io/meshkit/releases)
- [Commits](meshery/meshkit@v0.2.29...v0.2.30)

---
updated-dependencies:
- dependency-name: github.com/layer5io/meshkit
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Oct 10, 2021
@DelusionalOptimist
Copy link
Contributor

In this PR: meshery/meshkit#117, meshkit now needs newer version of some dependencies. However, controller-runtime seems to be incompatible with client-go v0.21.0 and thus causing operator build failures.

Here is some relevant info I found but I'm not sure what would be ideal:
https://www.henryxieblogs.com/2021/06/kubebuilder-controller-runtime.html
kubernetes-sigs/controller-runtime#1473

@panyuenlau @Utkarsh-pro please look into this.

panyuenlau
panyuenlau reviewed Oct 11, 2021
View reviewed changes
go.mod Outdated
k8s.io/client-go v0.18.12
k8s.io/api v0.21.0
k8s.io/apimachinery v0.21.0
k8s.io/client-go v0.21.0
sigs.k8s.io/controller-runtime v0.6.4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems controller-runtime starts to support Kubernetes v1.21 from v0.9.0-beta.0(see this PR), with this said, we need to update the controller-runtime package to v0.9.0 or later to support the Kubernetes packages upgrade here.

This requires some code changes, for example, the Reconcile() function signature got changed in this PR for v0.7.0 or later

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh I see 👀

@panyuenlau
Update controller Reconcile function signature
ba69ba8 
Signed-off-by: Pan Yuen Lau <panyuenlau@gmail.com>
@panyuenlau
Upgrade controller-runtime and Kubernetes dependencies
fc527c4 
Signed-off-by: Pan Yuen Lau <panyuenlau@gmail.com>
@panyuenlau panyuenlau mentioned this pull request Oct 11, 2021
Merged
1 task
@panyuenlau
Copy link
Member

panyuenlau commented Oct 11, 2021 •
edited

@DelusionalOptimist This PR #208 fixes the dependency issue that causes the build failure here, but not sure why the PR doesn't trigger the CI jobs

@DelusionalOptimist
Copy link
Contributor

@panyuenlau I merged your PR into this one as you had set the base branch to this originally.
The checks seem to be failing with a different error this time. Could that be due to old go version? 🤔

@panyuenlau
Copy link
Member

panyuenlau commented Oct 18, 2021 •
edited

@panyuenlau I merged your PR into this one as you had set the base branch to this originally. The checks seem to be failing with a different error this time. Could that be due to old go version? 🤔

@DelusionalOptimist Ahhh, I see why: the client-go v0.22.2 requires package io/fs, which is supported for go v1.16 or above (reference: https://pkg.go.dev/io/fs@go1.16.7?tab=versions), but it seems our pipeline still uses 1.14.15, and therefore it can't be built in the pipeline while I was able to build it in my local machine. With that said, we need to upgrade the golang to v1.16 or above to completely fix the build errors.

@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Oct 18, 2021

A newer version of github.com/layer5io/meshkit exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@leecalcote leecalcote mentioned this pull request Oct 18, 2021
Merged
1 task
@leecalcote
Copy link
Member

Bumping golang to v1.16 and re-running workflows.

@leecalcote
golintci upgrade
01af85f 
Signed-off-by: leecalcote <leecalcote@gmail.com>
@leecalcote
Merge branch 'master' into dependabot/go_modules/github.com/layer5io/…
c9c111f 
…meshkit-0.2.30
@leecalcote
Copy link
Member

All green lights on the build checks. Merging...

@leecalcote leecalcote merged commit d50269d into master Oct 18, 2021
@dependabot dependabot bot deleted the dependabot/go_modules/github.com/layer5io/meshkit-0.2.30 branch October 18, 2021 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panyuenlau panyuenlau panyuenlau left review comments

@DelusionalOptimist DelusionalOptimist Awaiting requested review from DelusionalOptimist

@tangledbytes tangledbytes Awaiting requested review from tangledbytes

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DelusionalOptimist @panyuenlau @leecalcote