Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Upgrade controller-runtime and Kubernete dependencies #208

Conversation

panyuenlau
Copy link
Member

@panyuenlau panyuenlau commented Oct 11, 2021

Description

This PR fixes build failures indicated in #207

Notes for Reviewers

Signed commits

  • Yes, I signed my commits.

Signed-off-by: Pan Yuen Lau <panyuenlau@gmail.com>
Signed-off-by: Pan Yuen Lau <panyuenlau@gmail.com>
@panyuenlau panyuenlau changed the title Dependabot/go modules/GitHub.com/layer5io/meshkit 0.2.30 Fix controller-runtime dependency Oct 11, 2021
@panyuenlau panyuenlau changed the title Fix controller-runtime dependency 🌱 Upgrade controller-runtime and Kubernete dependencies Oct 11, 2021
@DelusionalOptimist
Copy link
Contributor

@panyuenlau I pushed some stupid commits the other day while I was half asleep 😅.
Anyways, changing the base branch of this PR to master should trigger the build workflows and still maintain the overall effect of bumping meshkit.

@DelusionalOptimist DelusionalOptimist changed the base branch from dependabot/go_modules/github.com/layer5io/meshkit-0.2.30 to master October 17, 2021 19:32
@DelusionalOptimist
Copy link
Contributor

They didn't.... sigh.
Okay, I don't understand GitHub ;_;

@DelusionalOptimist DelusionalOptimist changed the base branch from master to dependabot/go_modules/github.com/layer5io/meshkit-0.2.30 October 17, 2021 19:36
@DelusionalOptimist DelusionalOptimist merged commit 070a9f4 into meshery:dependabot/go_modules/github.com/layer5io/meshkit-0.2.30 Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants