-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/layer5io/meshkit from 0.2.29 to 0.2.30 #207
Merged
leecalcote
merged 9 commits into
master
from
dependabot/go_modules/github.com/layer5io/meshkit-0.2.30
Oct 18, 2021
Merged
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0d23d4f
Bump github.com/layer5io/meshkit from 0.2.29 to 0.2.30
dependabot[bot] ba69ba8
Update controller Reconcile function signature
panyuenlau fc527c4
Upgrade controller-runtime and Kubernetes dependencies
panyuenlau 907aa6c
temporarily enable CI for PRs against non-master branches
DelusionalOptimist a5ee620
Revert "temporarily enable CI for PRs against non-master branches"
DelusionalOptimist 070a9f4
Merge pull request #208 from panyuenlau/dependabot/go_modules/github.…
DelusionalOptimist ee0c6e5
Merge branch 'master' into dependabot/go_modules/github.com/layer5io/…
leecalcote 01af85f
golintci upgrade
leecalcote c9c111f
Merge branch 'master' into dependabot/go_modules/github.com/layer5io/…
leecalcote File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems controller-runtime starts to support Kubernetes v1.21 from v0.9.0-beta.0(see this PR), with this said, we need to update the controller-runtime package to v0.9.0 or later to support the Kubernetes packages upgrade here.
This requires some code changes, for example, the Reconcile() function signature got changed in this PR for v0.7.0 or later
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ooh I see 👀