Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release CI workflow #2728

Merged
merged 5 commits into from Nov 8, 2022
Merged

Fix release CI workflow #2728

merged 5 commits into from Nov 8, 2022

Conversation

janosh
Copy link
Member

@janosh janosh commented Nov 8, 2022

I'm a bit confused after #2726 (comment). As I understand the docs, pyproject.toml's [build-system].requires is supposed to already handle installing numpy and cython prior to running setup.py so there should be no need for fetch_build_eggs.

But the failed release workflow suggests that's not happening. I think the only reason this hasn't come up in CI before is that the test.yml workflow installs m3gnet first, then pymatgen and m3gnet comes with numpy. Before #2707, all CI workflows installed requirements.txt first before running pip install . so unless I'm mistaken, the build-system.require hasn't actually setup the build-time requirements for a while?

run: |
pip install --upgrade pip wheel
pip install m3gnet
pip install -e '.[dev,optional]'
- name: pytest split ${{ matrix.split }}

@janosh
Copy link
Member Author

janosh commented Nov 8, 2022

@shyuep Maybe we use this hack in setup.py for now so we no longer rely on some other pip command installing numpy first before pip install .?

import subprocess

try:
    import numpy
except ImportError:
    subprocess.run(['pip', 'install', 'numpy'])
    import numpy

@coveralls
Copy link

coveralls commented Nov 8, 2022

Coverage Status

Coverage remained the same at 0.0% when pulling 32068db on fix-release-wf into d17a0f4 on master.

meant failed test would still show as green in CI!!
Fatal Python error: Segmentation fault

Current thread 0x00007fd88c24c740 (most recent call first):
  File "/opt/hostedtoolcache/Python/3.8.14/x64/lib/python3.8/site-packages/spglib/spglib.py", line 270 in get_magnetic_symmetry
  File "/opt/hostedtoolcache/Python/3.8.14/x64/lib/python3.8/site-packages/spglib/spglib.py", line 153 in get_symmetry
  File "/home/runner/work/pymatgen/pymatgen/pymatgen/symmetry/analyzer.py", line 219 in _get_symmetry
  File "/home/runner/work/pymatgen/pymatgen/pymatgen/symmetry/tests/test_analyzer.py", line 137 in test_get_symmetry
also add GibbsComputedStructureEntry to EntryLike Union
@janosh janosh enabled auto-merge November 8, 2022 21:38
@janosh janosh merged commit c70a590 into master Nov 8, 2022
@janosh janosh deleted the fix-release-wf branch November 8, 2022 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants