Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm a bit confused after #2726 (comment). As I understand the docs,
pyproject.toml
's[build-system].requires
is supposed to already handle installingnumpy
andcython
prior to runningsetup.py
so there should be no need forfetch_build_eggs
.But the failed release workflow suggests that's not happening. I think the only reason this hasn't come up in CI before is that the
test.yml
workflow installsm3gnet
first, thenpymatgen
andm3gnet
comes withnumpy
. Before #2707, all CI workflows installedrequirements.txt
first before runningpip install .
so unless I'm mistaken, thebuild-system.require
hasn't actually setup the build-time requirements for a while?pymatgen/.github/workflows/test.yml
Lines 51 to 55 in d17a0f4