Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release CI workflow #2728

Merged
merged 5 commits into from
Nov 8, 2022
Merged

Fix release CI workflow #2728

merged 5 commits into from
Nov 8, 2022

Commits on Nov 8, 2022

  1. merge .github/workflows/release.yml into test.yml

    @janosh
    janosh committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    33bb516 View commit details
    Browse the repository at this point in the history

  2. remove deprecated setup_requires from setup.py

    @janosh
    janosh committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    fee74a3 View commit details
    Browse the repository at this point in the history

  3. fix copy-paste error continue-on-error: true in test.yml's pytest step 

    meant failed test would still show as green in CI!!
    @janosh
    janosh committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    31b4191 View commit details
    Browse the repository at this point in the history

  4. pin up spglib>=2.0.2 to fix CI segfault 

    Fatal Python error: Segmentation fault

Current thread 0x00007fd88c24c740 (most recent call first):
  File "/opt/hostedtoolcache/Python/3.8.14/x64/lib/python3.8/site-packages/spglib/spglib.py", line 270 in get_magnetic_symmetry
  File "/opt/hostedtoolcache/Python/3.8.14/x64/lib/python3.8/site-packages/spglib/spglib.py", line 153 in get_symmetry
  File "/home/runner/work/pymatgen/pymatgen/pymatgen/symmetry/analyzer.py", line 219 in _get_symmetry
  File "/home/runner/work/pymatgen/pymatgen/pymatgen/symmetry/tests/test_analyzer.py", line 137 in test_get_symmetry
    @janosh
    janosh committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    205ea3e View commit details
    Browse the repository at this point in the history

  5. fix test_entry_like() not including all subclasses 

    also add GibbsComputedStructureEntry to EntryLike Union
    @janosh
    janosh committed Nov 8, 2022
    Configuration menu
    Copy the full SHA
    32068db View commit details
    Browse the repository at this point in the history