Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use build to build packages #2735

Merged
merged 1 commit into from
Nov 16, 2022
Merged

use build to build packages #2735

merged 1 commit into from
Nov 16, 2022

Conversation

njzjz
Copy link
Contributor

@njzjz njzjz commented Nov 15, 2022

Summary

Use build to release wheels.

I notice the current workflow to use python setup.py sdist bdist_wheel to build wheels, which will not follow build-system in pyproject.toml. I recommend the official PEP-517 build frontend, build. The dependencies are not required to be manually installed any more.

build documentation: https://pypa-build.readthedocs.io/en/stable/index.html

@shyuep shyuep disabled auto-merge November 16, 2022 02:43
@shyuep shyuep merged commit f039377 into materialsproject:master Nov 16, 2022
@shyuep
Copy link
Member

shyuep commented Nov 16, 2022

Thanks.

@janosh
Copy link
Member

janosh commented Nov 16, 2022

Ah, good to know! I was wondering why pyproject.toml seemed to be ignored in #2728.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants