[#16] [Frontend] As a User, I can sign up and sign in/out with a username and password #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malparty
added
$user-login
Generated by 🚫 Danger |
junan
reviewed
Jun 15, 2021
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| </a> | ||
| </div> | ||
| <div class="collapse" id="newPassword"> | ||
| <% if @minimum_password_length %> |
There was a problem hiding this comment.
| Replace instance variable with local variable |
| </div> | ||
| <div class="collapse" id="newPassword"> | ||
| <% if @minimum_password_length %> | ||
| <em>(<%= "#{@minimum_password_length} #{t('min_char')}" %>)</em> |
There was a problem hiding this comment.
| Replace instance variable with local variable |
junan
reviewed
Jun 21, 2021
junan
approved these changes
Jun 21, 2021
ankitkalia1195
approved these changes
Jun 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#16] [Frontend] As a User, I can sign up and sign in/out with a username and password
What happened
Added responsive user interface for the following views:
Insight
Most of the views are pure bootstrap. Only the footer is a new scss component.
You can test all with the following steps:
note that the "Forgot your password?" view is not part of this User Story.
Proof Of Work
Users/edit