Reroute to develop [#16] [Frontend] As a User, I can sign up and sign in/out with a username and password #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malparty
added
$user-login
malparty
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| </a> | ||
| </div> | ||
| <div class="collapse" id="newPassword"> | ||
| <% if @minimum_password_length %> |
There was a problem hiding this comment.
| Replace instance variable with local variable |
| </div> | ||
| <div class="collapse" id="newPassword"> | ||
| <% if @minimum_password_length %> | ||
| <em>(<%= "#{@minimum_password_length} #{t('min_char')}" %>)</em> |
There was a problem hiding this comment.
| Replace instance variable with local variable |
| </div> | ||
| <div class="form-group"> | ||
| <%= f.label :password %><br/> | ||
| <% if @minimum_password_length %> |
There was a problem hiding this comment.
| Replace instance variable with local variable |
| <div class="form-group"> | ||
| <%= f.label :password %><br/> | ||
| <% if @minimum_password_length %> | ||
| <em>(<%= "#{@minimum_password_length} #{t('min_char')}" %>)</em> |
There was a problem hiding this comment.
| Replace instance variable with local variable |
Generated by 🚫 Danger |
malparty
force-pushed
the
feature/user-login-backend
branch
from
5fb1d12
to
7156ceb
Compare
ankitkalia1195
approved these changes
Jun 23, 2021
junan
approved these changes
Jun 23, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains only changes from PR #37
I forgot to update the target of PR #37 to develop. So I just need to bring these changes into
developnow.Feature: