Release - 0.3.0 #50
Merged
Release - 0.3.0 #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| # frozen_string_literal: true | ||
|
|
||
| module API | ||
| module V1 |
| private | ||
|
|
||
| # helper method to access the current user from the token | ||
| def current_user |
There was a problem hiding this comment.
| Remove unused methods (api::v1::applicationcontroller#current_user) |
| # frozen_string_literal: true | ||
|
|
||
| module API | ||
| module V1 |
| include ErrorHandlerConcern | ||
|
|
||
| # Overridden from doorkeeper as the doorkeeper revoke action does not return response according to json-api spec | ||
| def revoke |
There was a problem hiding this comment.
| Remove unused methods (api::v1::tokenscontroller#revoke) |
| # The authorization server responds with HTTP status code 200 if the client | ||
| # submitted an invalid token or the token has been revoked successfully. | ||
| if token.blank? | ||
| render json: token_revoke_response, status: :ok |
There was a problem hiding this comment.
| Calls 'render json: token_revoke_response, status: :ok' 2 times |
| # of the error by the authorization server as described below. | ||
| elsif authorized? | ||
| revoke_token | ||
| render json: token_revoke_response, status: :ok |
There was a problem hiding this comment.
| Calls 'render json: token_revoke_response, status: :ok' 2 times |
| } | ||
| end | ||
|
|
||
| def token_revoke_response |
There was a problem hiding this comment.
| Doesn't depend on instance state (maybe move it to another class?) |
| # frozen_string_literal: true | ||
|
|
||
| module API | ||
| module V1 |
| # frozen_string_literal: true | ||
|
|
||
| module API | ||
| module V1 |
| render json: { errors: jsonapi_errors }, status: status | ||
| end | ||
|
|
||
| def build_error(detail:, source: nil, code: nil) |
There was a problem hiding this comment.
| Doesn't depend on instance state (maybe move it to another class?) |
| protected | ||
|
|
||
| def update_allowed_parameters | ||
| devise_parameter_sanitizer.permit(:sign_up) do |u| |
There was a problem hiding this comment.
| Has the variable name 'u' |
| devise_parameter_sanitizer.permit(:sign_up) do |u| | ||
| u.permit(:first_name, :last_name, :email, :password, :password_confirmation) | ||
| end | ||
| devise_parameter_sanitizer.permit(:account_update) do |u| |
There was a problem hiding this comment.
| Has the variable name 'u' |
| @@ -11,4 +11,25 @@ def self.authenticate(email, password) | |||
| user = User.find_for_authentication(email: email) | |||
| user&.valid_password?(password) ? user : nil | |||
There was a problem hiding this comment.
| Is controlled by argument 'password' |
| end | ||
|
|
||
| def as_json(_options = nil) | ||
| { errors: @errors.errors.map { |e| { detail: e.full_message, source: e.attribute } } } |
There was a problem hiding this comment.
| Refers to 'e' more than self (maybe move it to another class?) |
| end | ||
|
|
||
| def as_json(_options = nil) | ||
| { errors: @errors.errors.map { |e| { detail: e.full_message, source: e.attribute } } } |
There was a problem hiding this comment.
| Has the variable name 'e' |
| @uri = URI("#{BASE_SEARCH_URL}?q=#{@escaped_keyword}&hl=#{lang}&gl=#{lang}") | ||
| end | ||
|
|
||
| def call |
| return false unless valid_result? result | ||
|
|
||
| result | ||
| rescue HTTParty::Error, Timeout::Error, SocketError => e |
There was a problem hiding this comment.
| Has the variable name 'e' |
| </a> | ||
| </div> | ||
| <div class="collapse" id="newPassword"> | ||
| <% if @minimum_password_length %> |
There was a problem hiding this comment.
| Replace instance variable with local variable |
| </div> | ||
| <div class="collapse" id="newPassword"> | ||
| <% if @minimum_password_length %> | ||
| <em>(<%= "#{@minimum_password_length} #{t('min_char')}" %>)</em> |
There was a problem hiding this comment.
| Replace instance variable with local variable |
| </div> | ||
| <div class="form-group"> | ||
| <%= f.label :password %><br/> | ||
| <% if @minimum_password_length %> |
There was a problem hiding this comment.
| Replace instance variable with local variable |
Generated by 🚫 Danger |
| <div class="form-group"> | ||
| <%= f.label :password %><br/> | ||
| <% if @minimum_password_length %> | ||
| <em>(<%= "#{@minimum_password_length} #{t('min_char')}" %>)</em> |
There was a problem hiding this comment.
| Replace instance variable with local variable |
junan
approved these changes
Jun 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Chores
Bugs
N/A