Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#6 As a user, I can query a single keyword and get its Google search raw response #36

Merged
merged 47 commits into from Jun 24, 2021

Conversation

malparty
Copy link
Owner

#6 As a user, I can query a single keyword and get its Google search raw response

What happened

GoogleService::ClientService added to perform simple Google query.

Insight

  • Keywords#create added so that the user can query any keyword from the home page
  • Create view created to show the raw result (as nothing is parsed for this task)
  • Tests use a VCR cassette that reproduce a query. Note the usage of "vpn" keyword for the cassette query, this ensure to have AdWords in the result

To test: Run the app, perform a search and enjoy the google result.

Proof Of Work

Search form added: Result include Ads:
image image

@malparty malparty self-assigned this Jun 14, 2021
@malparty malparty added $keywords-query-single Query a single keyword at a given time @0.2.0 First usable release. Backend Feature priority: normal labels Jun 14, 2021
@malparty malparty added this to In development in Product backlog via automation Jun 14, 2021
@malparty malparty added this to the 0.2.0 milestone Jun 14, 2021
@github-actions
Copy link

github-actions bot commented Jun 14, 2021

6 Warnings
⚠️ spec/support/authentication_helper.rb#L27 - Has approx 8 statements
⚠️ spec/support/authentication_helper.rb#L36 - Is controlled by argument 'password_confirm'
⚠️ spec/support/vcr.rb#L42 - Has approx 8 statements
⚠️ spec/support/vcr.rb#L43 - Refers to 'vcr_options' more than self (maybe move it to another class?)
⚠️ spec/support/vcr.rb#L44 - Refers to 'vcr_options' more than self (maybe move it to another class?)
⚠️ spec/support/vcr.rb#L45 - Refers to 'vcr_options' more than self (maybe move it to another class?)

Generated by 🚫 Danger

@malparty malparty moved this from In development to In code review in Product backlog Jun 15, 2021
config/routes.rb Outdated Show resolved Hide resolved
@malparty malparty added the @0.3.0 v0.3.0 third week release label Jun 23, 2021
@malparty malparty modified the milestones: 0.2.0, 0.3.0 Jun 23, 2021
Product backlog automation moved this from In code review to Ready for QA Jun 24, 2021
@malparty malparty merged commit cf89874 into develop Jun 24, 2021
@malparty malparty deleted the feature/google-search-raw branch June 24, 2021 07:20
@malparty malparty modified the milestones: 0.3.0, 0.4.0 Jun 28, 2021
@malparty malparty moved this from Ready for QA to Completed in Product backlog Jun 28, 2021
@malparty malparty mentioned this pull request Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backend Feature $keywords-query-single Query a single keyword at a given time priority: normal @0.2.0 First usable release. @0.3.0 v0.3.0 third week release
Projects
Development

Successfully merging this pull request may close these issues.

As a user, I can query a single keyword and get its Google search raw response
3 participants