Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6 As a user, I can query a single keyword and get its Google search raw response #36

Merged
merged 47 commits into from Jun 24, 2021
Merged

#6 As a user, I can query a single keyword and get its Google search raw response #36

merged 47 commits into from Jun 24, 2021

Commits on Jun 23, 2021

  1. [#6] Add google client service

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    b402a7f View commit details
    Browse the repository at this point in the history

  2. [#6] Add basic create action and form to perform a google query

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    dbf2e9d View commit details
    Browse the repository at this point in the history

  3. [#6] Replace obsolete URI.encode by CGI.escape

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    89a9645 View commit details
    Browse the repository at this point in the history

  4. [#6] Add tests using VCR to replay a google search query

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    27fbc17 View commit details
    Browse the repository at this point in the history

  5. [#5] Generate Devise views

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    ccb4c85 View commit details
    Browse the repository at this point in the history

  6. [#5] Add lastname and firstname to registration views

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    b180494 View commit details
    Browse the repository at this point in the history

  7. Rebase from develop routes

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    3c0b3d3 View commit details
    Browse the repository at this point in the history

  8. Rebase from develop pull

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    f430136 View commit details
    Browse the repository at this point in the history

  9. Rebase from develop pull

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    18c3631 View commit details
    Browse the repository at this point in the history

  10. root commit

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    a2d7d94 View commit details
    Browse the repository at this point in the history

  11. [#5] Rename lastname/firstname into last_name first_name

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    36900b1 View commit details
    Browse the repository at this point in the history

  12. [#5] Fix missing renaming for lastname firstname

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    9de1276 View commit details
    Browse the repository at this point in the history

  13. [#5] Merge email (citext) and renaming names into previous db migrations

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    5184e73 View commit details
    Browse the repository at this point in the history

  14. [#6] Declare vcr inline to improve code readability

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    8b3ffc0 View commit details
    Browse the repository at this point in the history

  15. [#6] Replace instance variables by local variables inside view

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    11f09cd View commit details
    Browse the repository at this point in the history

  16. [#6] Handle error while query google - not colorized

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    f60ba32 View commit details
    Browse the repository at this point in the history

  17. [#6] Review methods order and exposure

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    2441302 View commit details
    Browse the repository at this point in the history

  18. [#6] Update tests from class method to instance methods

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    1af4e64 View commit details
    Browse the repository at this point in the history

  19. [#6] Colorize logs from Rails.logger

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    0236a3a View commit details
    Browse the repository at this point in the history

  20. root commit

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    5a52417 View commit details
    Browse the repository at this point in the history

  21. root commit

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    67171f8 View commit details
    Browse the repository at this point in the history

  22. [#6] Improve create action readability

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    242c5db View commit details
    Browse the repository at this point in the history

  23. [#6] Remove create action and index form

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    c74da8a View commit details
    Browse the repository at this point in the history

  24. [#6] remove useless require

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    d289a9b View commit details
    Browse the repository at this point in the history

  25. [#6] Set base url google as constant

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    603ac8e View commit details
    Browse the repository at this point in the history

  26. [#6] Fix formatting warnings

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    b2f1d52 View commit details
    Browse the repository at this point in the history

  27. [#6] Rename query_result in call

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    d233c30 View commit details
    Browse the repository at this point in the history

  28. [#6] Use keyword arguments to initialize service

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    8ace4ab View commit details
    Browse the repository at this point in the history

  29. [#6] Rename GoogleService namespace in Google

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    f409671 View commit details
    Browse the repository at this point in the history

  30. [#6] Rename GoogleService namespace in Google

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    a50ea52 View commit details
    Browse the repository at this point in the history

  31. [#6] Fix test to map keyword arguments

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    73dac87 View commit details
    Browse the repository at this point in the history

  32. [#6] Review implementation of ClientService.call to be less risky wit… 

    …h result edition
    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    dbaa2dd View commit details
    Browse the repository at this point in the history

  33. [#6] Fix rubocop empty line

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    3b993d8 View commit details
    Browse the repository at this point in the history

  34. [#6] Fix nil keyword in error messages

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    4f4805c View commit details
    Browse the repository at this point in the history

  35. [#6] Fix rubocop warnings

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    f9d9607 View commit details
    Browse the repository at this point in the history

  36. [#6] Improve tests to cover result validation

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    36c0d94 View commit details
    Browse the repository at this point in the history

  37. [#6] Improve tests to cover result validation - spelling fix

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    500bda9 View commit details
    Browse the repository at this point in the history

  38. [#6] Improve call method for worker retrial ease

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    44ef5d2 View commit details
    Browse the repository at this point in the history

  39. [#6] Rename validate_result in valid_result?

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    ab621cc View commit details
    Browse the repository at this point in the history

  40. Update Gemfile Httparty comment 

    Co-authored-by: Junan Chakma <junan.cs@gmail.com>
    @malparty @junan
    malparty and junan committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    5d8ec49 View commit details
    Browse the repository at this point in the history

  41. Replace nil by false in clientservice spec 

    Co-authored-by: Junan Chakma <junan.cs@gmail.com>
    @malparty @junan
    malparty and junan committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    dd4b0f8 View commit details
    Browse the repository at this point in the history

  42. [#6] Update client service spec with const google url instead of hard… 

    …coded
    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    0e68db9 View commit details
    Browse the repository at this point in the history

  43. [#6] Update client service valid_result? method to return true when v… 

    …alid
    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    902742d View commit details
    Browse the repository at this point in the history

  44. [#6] Replace falsy by eq(false) in client service spec test

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    93704d4 View commit details
    Browse the repository at this point in the history

  45. [#6] Remove optional comment

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    4c5bed3 View commit details
    Browse the repository at this point in the history

  46. [#6] Rebase from develop had wrong schema version

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    777e61b View commit details
    Browse the repository at this point in the history

  47. Merge branch 'develop' into feature/google-search-raw

    @malparty
    malparty committed Jun 23, 2021
    Configuration menu
    Copy the full SHA
    8dbecbc View commit details
    Browse the repository at this point in the history