Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#7] [Backend] As a User, I can query a single keyword and get its Google search results parsed #39

Merged
merged 80 commits into from Jul 1, 2021
Merged

[#7] [Backend] As a User, I can query a single keyword and get its Google search results parsed #39

merged 80 commits into from Jul 1, 2021

Conversation

malparty
Copy link
Owner

@malparty malparty commented Jun 18, 2021 •
edited

What happened

Parse the HTML content from previously done search queries.

Insight

  • Open rails console
  • Create a search (from previous PR feature): result = GoogleService::ClientService.new('YOUR KEYWORD').query_result; nil (note the final ; nil is just here to avoid getting the html result in console output)
  • Finally parse the search with parsed = GoogleService::ParserService.new(result); nil
  • Now you can check all the parsed fields from parsed variable: ads_top_count, ads_page_count, ads_top_url, ads_page_url, non_ads_result_count, total_link_count

Proof Of Work

Keyword used: vpn
image

Keyword used: squarespace

image

@malparty malparty added $keywords-query-single Query a single keyword at a given time @0.2.0 First usable release. @0.3.0 v0.3.0 third week release Feature Backend priority: normal labels Jun 18, 2021
@malparty malparty added this to the 0.2.0 milestone Jun 18, 2021
@malparty malparty self-assigned this Jun 18, 2021
@malparty malparty added this to In development in Product backlog via automation Jun 18, 2021
github-actions[bot]
github-actions bot reviewed Jun 22, 2021
View reviewed changes
app/services/google/parser_service.rb Outdated

# Write parsed data directly in the keyword object argument
# and return back the keyword object
def parse_into!(keyword)
Copy link

@github-actions github-actions bot Jun 22, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Has missing safe method 'parse_into!'

github-actions[bot]
github-actions bot reviewed Jun 22, 2021
View reviewed changes
app/services/google/parser_service.rb Outdated

# Write parsed data directly in the keyword object argument
# and return back the keyword object
def parse_into!(keyword)
Copy link

@github-actions github-actions bot Jun 22, 2021 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Has approx 8 statements

@github-actions
Copy link

github-actions bot commented Jun 22, 2021 •
edited

4 Warnings
⚠️ spec/support/vcr.rb#L46 - Has approx 8 statements
⚠️ spec/support/vcr.rb#L47 - Refers to 'vcr_options' more than self (maybe move it to another class?)
⚠️ spec/support/vcr.rb#L48 - Refers to 'vcr_options' more than self (maybe move it to another class?)
⚠️ spec/support/vcr.rb#L49 - Refers to 'vcr_options' more than self (maybe move it to another class?)

Generated by 🚫 Danger

@malparty malparty force-pushed the feature/google-search-parsed branch from e3d0729 to 1b0bfbb Compare June 23, 2021 01:52
@malparty malparty force-pushed the feature/google-search-parsed branch from 41fea83 to 8cb43a3 Compare June 23, 2021 10:10
@malparty malparty moved this from In development to In code review in Product backlog Jun 23, 2021
@malparty malparty modified the milestones: 0.2.0, 0.3.0 Jun 23, 2021
@malparty malparty changed the title WIP - [#7] [Backend] As a User, I can query a single keyword and get its Google search results parsed [#7] [Backend] As a User, I can query a single keyword and get its Google search results parsed Jun 24, 2021
Base automatically changed from feature/google-search-raw to develop June 24, 2021 07:20
@malparty malparty linked an issue Jun 24, 2021 that may be closed by this pull request
[Backend] As a User, I can query a single keyword and get its Google search results parsed #7
Closed
@malparty malparty modified the milestones: 0.3.0, 0.4.0 Jun 28, 2021
@malparty malparty force-pushed the feature/google-search-parsed branch from 2b1abae to eb09e27 Compare June 28, 2021 09:49
@malparty
root commit
a817125
@malparty
root commit
b751213
@malparty
root commit
4e8c6d6
@malparty
root commit
a4e09d0
@malparty
[#7] Rename GoogleService namespace in Google
9ed9447 
Rebase from google-search-raw
@malparty
[#7] Rename GoogleService namespace in Google missing folder
ca3c0a7 
Rebase from feature-google-search-raw
@malparty
[#7] Update service tests to call with keyword arguments
6c43759
@malparty
[#7] Update client service to match rebase code
c34874f
@malparty
[#7] Fix rubocop indentation
dff824b
@malparty
[#7] Remove useless require nokogiri statment
edcb48d
@malparty
[#7] Use constants to DRY parser css selectors
55783b5
@malparty
[#7] Rebase from search-raw after user-login-api merge
438507e
@malparty
[#7] Rebase from search-raw remove missed file
aa3a43f
@malparty
[#7] Remove unwanted form in keyword#index view
3688817
@malparty
[#7] Fix parser service with call mthod and return hash of attribute
88e9a61
@malparty
[#7] Rename vcr to simpler google_search/xx name
bdd4d8a
@malparty
[#7] Migrate DB after rebase
070abd5
@malparty
[#7] Migrate DB after rebase - fix missing forzen string literal
e0a42da
@malparty malparty force-pushed the feature/google-search-parsed branch from bdf9804 to e0a42da Compare June 30, 2021 06:56
Product backlog automation moved this from In code review to Ready for QA Jun 30, 2021
@malparty malparty merged commit f5fbcf6 into develop Jul 1, 2021
@malparty malparty deleted the feature/google-search-parsed branch July 1, 2021 02:10
@malparty malparty mentioned this pull request Jul 1, 2021
Merged
@malparty malparty moved this from Ready for QA to Completed in Product backlog Jul 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions left review comments

@junan junan junan approved these changes

@ankitkalia1195 ankitkalia1195 ankitkalia1195 approved these changes

Assignees

@malparty malparty

Labels
Backend Feature $keywords-query-single Query a single keyword at a given time priority: normal @0.2.0 First usable release. @0.3.0 v0.3.0 third week release
Projects
Product backlog
Completed
Milestone
0.4.0
Development

Successfully merging this pull request may close these issues.

[Backend] As a User, I can query a single keyword and get its Google search results parsed
3 participants
@malparty @junan @ankitkalia1195